Feat: route for editing team member role #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
e11sy
commented
Jan 8, 2024
e11sy
commented
- added route for editing team member role
- added test for this route
- added test data for note-teams
- added function to write test data into database
- added route for editing team member role - added test for this route - added test data for note-teams - added function to write test data into database
- new tests added - enum with no strings
- changed id in test data
e11sy
force-pushed
the
edit-team-member-role
branch
from
583915d to
7e8722d
Compare
- added route for editing team member role - added test for this route - added test data for note-teams - added function to write test data into database
- new tests added - enum with no strings
…/notes.api into edit-team-member-role
- type of role changed to typeof keyof MemberRole - fixed some test data
- deleted unwanted output
elizachi
reviewed
Jan 12, 2024
- changed tests description - deleted unwanted semicolon
neSpecc
reviewed
Jan 13, 2024
elizachi
approved these changes
Jan 14, 2024
- parameters now pass in Params, not in body - now we dont use noteInternalId - added schema to validate notePublicId
- added todo for new policy for this route - deleted unwanted spaces in output
neSpecc
reviewed
Jan 14, 2024
- keyof typeof MemberRole now is MemberRoleKeys - comments changed
- todo changed
added new comments for note teams test
- switched back to memberRole because newRole passing is 0 | 1
neSpecc
reviewed
Jan 20, 2024
- moved newRole to body - changed url for route - added comments
- moved userId to body in route - changed tests
- added comments
neSpecc
reviewed
Jan 20, 2024
- test description updated
neSpecc
approved these changes
Jan 20, 2024
- added docs
TatianaFomina
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.