Expose note publicId as id property #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added logic to wrap Note and NoteList to expose public id before sending to frontend
- Changed tests to accept note only with public id
neSpecc
requested changes
Nov 25, 2023
…-team/notes.api into chore/get-note-by-id-tests
|
please fix the tests |
In process 👌 |
… chore/get-note-by-id-tests
… chore/get-note-by-id-tests
settings attached, if not then it should be null
TatianaFomina
requested changes
Dec 10, 2023
TatianaFomina
approved these changes
Jan 14, 2024
neSpecc
reviewed
Jan 18, 2024
- Got rid of public noteSetting
neSpecc
reviewed
Jan 28, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
neSpecc
reviewed
Feb 7, 2024
TatianaFomina
approved these changes
Feb 10, 2024
neSpecc
reviewed
Feb 10, 2024
neSpecc
approved these changes
Feb 10, 2024
TatianaFomina
changed the title
kloV148
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now note is returned "id" which is public id. The tests have been finalized to reflect this change.