Review changes

src/domain/entities/noteList.ts

@@ -1,5 +1,8 @@
 import type { Note } from '@domain/entities/note.js';
 
+/**
+ * Note list  entity
+ */
 export type NoteList = {
   items: Note[];
 };

src/domain/service/noteList.ts

@@ -17,12 +17,12 @@ export default class NoteListService {
   }
 
   /**
-   * Gets note list by creator id
+   * Returns note list by creator id
    *
    * @param id - note creator id
-   * @returns { Promise<NoteList | null> } note
+   * @returns { Promise<NoteList> } note
    */
-  public async getNoteListByCreatorId(id: number): Promise<NoteList | null> {
+  public async getNoteListByCreatorId(id: number): Promise<NoteList> {
     return await this.repository.getNoteListByCreatorId(id);
   }
 }

src/presentation/http/router/noteList.ts

@@ -38,18 +38,6 @@ const NoteListRouter: FastifyPluginCallback<NoteListRouterOptions> = (fastify, o
     const { userId } = request;
     const noteList = await noteListService.getNoteListByCreatorId(userId as number);
 
-    /**
-     * Check if note list does not exist
-     */
-    if (!noteList) {
-      const response: ErrorResponse = {
-        code: StatusCodes.NOT_FOUND,
-        message: 'Note list not found',
-      };
-
-      return reply.send(response);
-    }
-
     return reply.send(noteList);
   });
 

src/repository/note.repository.ts

@@ -74,9 +74,9 @@ export default class NoteRepository {
    * Gets note list by creator id
    *
    * @param id - note creator id
-   * @returns { Promise<NoteList | null> } note
+   * @returns { Promise<NoteList> } note
    */
-  public async getNoteListByCreatorId(id: number): Promise<NoteList | null> {
+  public async getNoteListByCreatorId(id: number): Promise<NoteList> {
     return await this.storage.getNoteListByCreatorId(id);
   }
 }

src/repository/storage/postgres/orm/sequelize/note.ts

@@ -190,19 +190,15 @@ export default class NoteSequelizeStorage {
    * Gets note list by creator id
    *
    * @param creatorId - note creator id
-   * @returns { Promise<NoteList | null> } note
+   * @returns { Promise<NoteList> } note
    */
-  public async getNoteListByCreatorId(creatorId: number): Promise<NoteList | null> {
+  public async getNoteListByCreatorId(creatorId: number): Promise<NoteList> {
     const noteList  = await this.model.findAll({
       where: {
         creatorId,
       },
     });
 
-    if (noteList.length === 0) {
-      return null;
-    }
-
     return {
       items: noteList,
     };