feat(notifier): new notification pattern #326
Open
+450
−818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added redis helper class and some methods for digest and threshold storing - added env.sample for redis connections - added dependencies related to redis
- add notifier method to get threshold from redis or from db - add notifier method to check if event is critical - updated lock
- get rid of the buffer - move types to types directory - improve old comments
neSpecc
reviewed
Dec 18, 2024
workers/notifier/src/redisHelper.ts
Outdated
| // return 1 if period has been reset | ||
| return 1 | ||
| else | ||
| local newCounter = redis.call("HINCRBY", key, "counter", 1) |
There was a problem hiding this comment.
Suggested change
| local newCounter = redis.call("HINCRBY", key, "counter", 1) | |
| local newCounter = redis.call("HINCRBY", key, "eventsCount", 1) |
to support "usersCount" in a future
slaveeks
approved these changes
Dec 21, 2024
e11sy
changed the title
neSpecc
reviewed
Dec 25, 2024
| return newCounter | ||
| `; | ||
|
|
||
| const key = `${ruleId}:${groupHash}:${thresholdPeriod}:times`; |
There was a problem hiding this comment.
Suggested change
| const key = `${ruleId}:${groupHash}:${thresholdPeriod}:times`; | |
| const key = `${ruleId}:${groupHash}:${thresholdPeriod}`; |
neSpecc
reviewed
Dec 25, 2024
| return newCounter | ||
| `; | ||
|
|
||
| const key = `${ruleId}:${groupHash}:${thresholdPeriod}:times`; |
There was a problem hiding this comment.
key should also include workspace id and project id
`${workspaceId}:${projectId}:${ruleId}:${groupHash}:${thresholdPeriod}`
neSpecc
reviewed
Dec 25, 2024
| }); | ||
| for (const rule of rules) { | ||
| /** | ||
| * If rule is enabled no need to store data in redis |
There was a problem hiding this comment.
Suggested change
| * If rule is enabled no need to store data in redis | |
| * If rule is disabled no need to store data in redis |
neSpecc
reviewed
Dec 25, 2024
| @@ -130,10 +128,10 @@ export default class NotifierWorker extends Worker { | |||
| * @param {Rule} rule - notification rule | |||
| * @param {NotifierEvent} event - received event | |||
| */ | |||
| private addEventToChannels(projectId: string, rule: Rule, event: NotifierEvent): void { | |||
| private async addEventToChannels(projectId: string, rule: Rule, event: NotifierEvent): Promise<void> { | |||
There was a problem hiding this comment.
Suggested change
| private async addEventToChannels(projectId: string, rule: Rule, event: NotifierEvent): Promise<void> { | |
| private async sendEventToChannels(projectId: string, rule: Rule, event: NotifierEvent): Promise<void> { |
e11sy
changed the title
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a part of the new notification system
check full design of this feature in figma file
What is new
Now on worker side we will have
criticalandnoncriticalevents (users would not know about terminology)Event rule would be formed as:
threshold, same aseventThresholdPeriodwould be determined in garage by user in rule confugurationWhat is notifications
threshold?Notifications
thresholdis a new term.thresholdrepetitions ineventTresholdPeriod, than event is critical and should be sent imidiatelyImplemented
redisHelperclass for storing of the digest and project thresholdsrulesremains)redis-mocklib