Clean up for v1 #30
Clean up for v1 #30
Conversation
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "marked-extensions", | |||
| "version": "0.5.0", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
Wasn't expecting v1. I think we have more to discuss, clean up, and should make sure this can be actually used. I can also set up automation, so we don't need to commit dist/.
There was a problem hiding this comment.
I'll open issues that I think we need to resolve before v1.
Edit: https://github.com/codewars/marked-extensions/milestone/1
There was a problem hiding this comment.
Yeah I went for v1 because it was technically breaking changes. Since we are going full milestone on this, @ggorlen you might want to chime in with your notes.
There was a problem hiding this comment.
Minor bumps before v1 are breaking changes, so we don't need to jump to v1 for semver.
There was a problem hiding this comment.
Ah good to know. I think we can stick with v1. I like the milestone on this, let's get all of the major issues out of the way now so that we don't end up kicking the can down the road. @ggorlen can you help tackle some of the milestone tasks Kaz filed?
There was a problem hiding this comment.
Going for v1 sounds good, but let's keep the version in this PR, so we can bump the version before actually releasing (possibly by automation).
| "version": "1.0.0", | |
| "version": "0.5.0", |
There was a problem hiding this comment.
@jhoffner My notes are pretty much updating headers to match whatever format the language generator's spitting out. LG headers have gotten more complex and language-specific because I'm using type annotations for Python and PHP, syntax like const and & in C++, supporting languages like Dart, Elixir, R and Rust, as well as minor changes like ArrayList instead of List or T[] in Java and changing casing in Go. I can apply these changes to ME but I'm not sure how invasive it'll be on the current design or if it's even necessary to show the types inline exactly as they appear in the code.
There was a problem hiding this comment.
@ggorlen Can you open a new issue to discuss? I also have some inputs for the generator that I'll probably open later.
This comment has been minimized.
This comment has been minimized.
🦋 Changeset detectedLatest commit: 2b3ee26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Removed CM support. Utilize `highlight` function with CM directly if you wish to use this - Removed lineNumbers support, this may be added in later if a universal way of handling it is found - Simplified extensions, loadScript support was removed, extensions need to load their own resources - Removed Mermaid support, this can be added later as an external extension - Upgraded `marked` from 0.6.2 to 2.1.1 and added to peer dependencies - Removed `findLanguage` option, now just assumes anything unknown is a language
highlightfunction with CM directly if you wish to use thisfindLanguageoption, now just assumes anything unknown is a language