[bean] step-2 구현 #85
Merged
[bean] step-2 구현 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honux77
reviewed
Mar 8, 2023
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public class LadderV1 implements Ladder { |
There was a problem hiding this comment.
V1 V2와 같은 네이밍은 피하는 게 좋습니다.
그리고 지금 현재 필요하지 않은 클래스가 있다면 이전 커밋에 남아 있으니 과감하게 삭제해 주세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step-2, step-3에서 만든 각각의 Ladder 클래스를 깔끔하게 교체를 하는 방법에 대해 고민을 했습니다.
그리고 이번에는 예외 처리와 테스트 코드에 학습을 했습니다.