Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Goodies page #898

Merged
merged 10 commits into from
Aug 28, 2024
Merged

add Goodies page #898

merged 10 commits into from
Aug 28, 2024

Conversation

samumantha
Copy link
Contributor

  • Is goodies a good word? Or should it be merch or something else?
  • Please check the image size (cannot currently build locally, size is just a guess)

Please read carfully and feel free to edit :)

@samumantha samumantha requested a review from bast August 28, 2024 10:04
@bast
Copy link
Member

bast commented Aug 28, 2024

All good - thank you! - but please reduce the image size so that we have faster page load and less git repo bloat.

@samumantha
Copy link
Contributor Author

Ah, good point, forgot.
Now reduced; for later: What is a good image size for websites?

@bast
Copy link
Member

bast commented Aug 28, 2024

Ah, good point, forgot. Now reduced; for later: What is a good image size for websites?

I am aiming at 200-300 kB or less. We will need to squash-merge otherwise the big file remains in history.

@bast bast merged commit d4209ea into main Aug 28, 2024
2 checks passed
@bast bast deleted the goodies branch August 28, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants