-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add listing email response using notify button #155
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for coderdojobraga-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for coderdojobraga-blog canceled.
|
✅ Deploy Preview for coderdojobraga-web canceled.
|
Instead of using a modal, it may make more sense to create a route such as /admin/mailbox to display all sent emails, as is done in the Phoenix Framework. |
@MarioRodrigues10 Why would a page be better? |
Unlike a modal, which is temporary, displaying sent emails on a route like /admin/mailbox would allow the admin to access them permanently and view them sorted by their send date. |
But how can shuriken access the sent emails? That's a capability not provided by bokken, hence the use of a modal (which is "temporary"). |
Access to the sent emails could be provided through |
Documentation says:
And this is the way to go, since what you mention it's not directly suitable for shuriken. |
I agree, perhaps we only need to modify an if statement in router.ex and add logic to restrict access to only organizers to allow access to the route. |
✅ Deploy Preview for coderdojobraga-maintenance canceled.
|
✅ Deploy Preview for coderdojobraga-blog canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
return ( | ||
<Modal | ||
title={modalTitle} | ||
visible={visible} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visible={visible} | |
open={visible} |
visible
is deprecated which will be removed in next the major version of AntDesign. Use open
instead 🙏🏻
No description provided.