Modernize Gradle and Kotlin #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeniko
approved these changes
Sep 24, 2022
| @@ -313,7 +308,7 @@ internal data class DeepScanArrayAccessorToken(val indices: List<Int>) : Token { | |||
| } | |||
| } | |||
|
|
|||
| override fun read(json: JsonNode): JsonNode? { | |||
There was a problem hiding this comment.
Nice! Not sure how I missed this and the other nullables when I wrote it
There was a problem hiding this comment.
I think they might have improved something in Kotlin because I wasn't seeing warnings before updating it
|
Thanks for the contribution! Auto release pipeline not necessary but I'll likely merge such a change too |
|
Just realized the code coverage reporting is missing, I can look into that later |
|
I see what happened with the missing code coverage. I'll make a PR for that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Kotlin to 1.7.10
Update Gradle to 7.5.1
Use Gradle Kotlin DSL instead of Groovy
I hope to get to #7 sometime this week.
I may have broken the benchmark format. I'll take a closer look at that soon.
I probably also broke publishing; I can make some changes there later, and get you up and running with an automated release pipeline using GitHub Actions if you want.