throw a specific error if user isnt found when syncing time entries

codelittinc · Nov 6, 2023 · f6d65d4 · f6d65d4
1 parent a41a4a2
commit f6d65d4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 58 deletions.
diff --git a/app/controllers/time_entries_controller.rb b/app/controllers/time_entries_controller.rb
diff --git a/app/services/team_maker_project_creator.rb b/app/services/team_maker_project_creator.rb
@@ -20,8 +20,7 @@ def call
 
   def create_time_entires!(team_maker_project_time_entries)
     team_maker_project_time_entries.each do |time_entry|
-      user = User.find_by(email: time_entry.resource)
-      next if user.nil?
+      user = find_user(time_entry.resource)
 
       TimeEntry.create!(
         statement_of_work:,
@@ -41,7 +40,7 @@ def create_requirements!(team_maker_project_requirements)
 
   def create_assignments!(team_maker_project_assignments, requirement)
     team_maker_project_assignments.each do |assignment|
-      user = User.find_by(email: assignment.resource)
+      user = find_user(assignment.resource)
 
       Assignment.create!(
         requirement:,
@@ -85,4 +84,11 @@ def statement_of_work
     @statement_of_work.requirements.destroy_all
     @statement_of_work
   end
+
+  def find_user(email)
+    user = User.find_by(email:)
+    raise StandardError, "User with email #{email} does not exist" if user.nil?
+
+    user
+  end
 end