Merge pull request #123 from codelitdev/issue-118-2

Thumbnail optimization
codelitdev · Apr 8, 2024 · f52d459 · f52d459
2 parents 063a5b7 + 34b30ff
commit f52d459
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/apps/api/src/config/constants.ts b/apps/api/src/config/constants.ts
@@ -13,7 +13,7 @@ export const APIKEY_RESTRICTION_CUSTOM = "custom";
 export const tempFileDirForUploads = process.env.TEMP_FILE_DIR_FOR_UPLOADS;
 export const maxFileUploadSize = process.env.MAX_UPLOAD_SIZE || 2147483648;
 export const imagePattern = /^image\/(jpe?g|png)$/;
-export const imagePatternIncludingGif = /^image\/(jpe?g|png|gif)$/;
+export const imagePatternIncludingGif = /^image\/(jpe?g|png|gif|webp)$/;
 export const videoPattern = /video/;
 export const cloudEndpoint = process.env.CLOUD_ENDPOINT || "";
 export const cloudRegion = process.env.CLOUD_REGION || "";

diff --git a/packages/thumbnail/bin/generate-thumbnail.sh b/packages/thumbnail/bin/generate-thumbnail.sh
@@ -4,6 +4,8 @@
 input_image="$1"
 # Output thumbnail path
 output_thumbnail="$2"
+# Crop the image to 16:9 if necessary and resize to a lower resolution if height > desired_height, otherwise keep original height
+desired_height=${3:-480}
 
 # Check if input image is provided
 if [[ -z "$input_image" ]]; then
@@ -25,12 +27,12 @@ else
   target_width=$width
 fi
 
-# Crop the image to 16:9 if necessary and resize to 720p if height > 720, otherwise keep original height
-if [ $target_height -le 720 ]; then
-  final_height=$target_height
+
+if [ $target_height -le $desired_height ]; then
+    final_height=$target_height
 else
-  final_height=720
-  target_width=$((final_height * 16 / 9))
+    final_height=$desired_height
+    target_width=$((final_height * 16 / 9))
 fi
 
 # Generate the thumbnail