-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 김세환 sprint5 #48
Merged
seobew
merged 8 commits into
codeit-sprint-fullstack:react-김세환
from
CisThard:react-김세환-sprint5
Dec 9, 2024
The head ref may contain hidden characters: "react-\uAE40\uC138\uD658-sprint5"
Merged
React 김세환 sprint5 #48
seobew
merged 8 commits into
codeit-sprint-fullstack:react-김세환
from
CisThard:react-김세환-sprint5
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CisThard
added
매운맛🔥
뒤는 없습니다. 그냥 필터 없이 말해주세요. 책임은 제가 집니다.
제출일 이후 제출한PR
제출 마감일(일요일) 이후에 제출하는 PR입니다.
최종 제출
스프린트미션 최종 제출본입니다.
labels
Dec 4, 2024
seobew
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
세환님 이번 스프린트 고생하셨습니다!
create-react-app으로 기본구조를 가져가서 리뷰하는 저도 익숙했습니다 ㅎㅎ
전체적으로 깔끔하게 잘 해주셨는데,
몇개 코멘트를 남겨놨습니다!
확인후 질문 있으시면 말씀해주세요~
수고하셨습니다!
seobew
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
매운맛🔥
뒤는 없습니다. 그냥 필터 없이 말해주세요. 책임은 제가 집니다.
제출일 이후 제출한PR
제출 마감일(일요일) 이후에 제출하는 PR입니다.
최종 제출
스프린트미션 최종 제출본입니다.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기본 요구사항
공통
중고마켓 페이지
/
에 보이도록 합니다."/products"
를 활용해 주세요."/products"
의 정렬 기준favorite
을 사용해 주세요.심화 요구사항
공통
중고마켓 페이지
pageSize
값을 적절하게 설정합니다.주요 변경사항
스크린샷
멘토에게