[조형민] sprint7 이후 수정 내용 반영입니다. 멘토님 가능하실 때 머지 부탁드립니다. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seobew
reviewed
Jan 14, 2025
| res.sendStatus(404); | ||
| } else { | ||
| res.status(500).send({ | ||
| message: e.message, |
There was a problem hiding this comment.
e에서 message 가 존재하지 않을수 있습니다. 모든 케이스에서 충족시키는 것이 없을때는 "Internal Server Error"같이 내려주는 것이 더 좋을것 같습니다~
seobew
reviewed
Jan 14, 2025
| e instanceof Prisma.PrismaClientKnownRequestError && | ||
| e.code === 'P2025' | ||
| ) { | ||
| res.sendStatus(404); |
There was a problem hiding this comment.
여기도 message 를 내려주는게 fe에서 에러 보여주기 더 좋을것 같아요. 통일성도 있고요!
seobew
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게