Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paengdal
added
매운맛🔥
seobew
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
여기는 node.js 쪽이라 react 관련된 lint 는 필요없어서 해당 부분 지워주시면 좋을것 같습니다 ㅎㅎ
There was a problem hiding this comment.
다음시간에 환경변수 관련되서 말씀드리겠지만, 보통 .env는 github에 올리지는 않고 따로 관리를 합니다 ㅎㅎ
| @@ -0,0 +1,23 @@ | |||
| -- CreateTable | |||
| CREATE TABLE "Product" ( | |||
| "id" TEXT NOT NULL, | |||
There was a problem hiding this comment.
보통 mysql이나 다른 db에서는 TEXT가 아닌 VARCHAR를 쓰게끔 하는데요
postgresql을 사용하셔서 TEXT를 사용하셔도 성능상 이슈는 없지만, 보통 길이가 엄청 길지 않는 이상 (product.description 등) VARCHAR을 사용하긴 합니다 ㅎㅎ
| const comment = await prisma.comment.create({ data: req.body }); | ||
|
|
||
| // 해당 게시글에 댓글을 연결 | ||
| const { id: commentId } = comment; |
| assert(req.body, PatchComment); | ||
| const { id } = req.params; | ||
| const comment = await prisma.comment.update({ where: { id }, data: { ...req.body } }); | ||
| res.send(comment); |
There was a problem hiding this comment.
여기도 통일성 있게 res.status(200).send(comment)로 해주는게 더 좋을듯 합니다.
| app.patch( | ||
| '/comments/:id', | ||
| asyncHandler(async (req, res) => { | ||
| assert(req.body, PatchComment); |
There was a problem hiding this comment.
오.. 이런 assert 로 validation 추가해주시다니 좋네요 ㅎㅎ
| const nextCursor = lastComment.id; | ||
| const isLastPage = limit > comments.length; | ||
| // 최종적으로 cursor와 comments 전달 | ||
| const finalData = isLastPage |
There was a problem hiding this comment.
이런 로직은 위에도 중복코드가 있어서 따로 함수를 빼서 범용적으로 사용할수 있게 하면 더 좋을듯 합니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본 요구사항
중고마켓
공통
자유게시판
댓글
심화 요구사항
주요 변경사항
스크린샷
멘토에게