-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipeline description to spec to match API #71
Add pipeline description to spec to match API #71
Conversation
@Jake-Mok-Nelson Can you point me where in API you saw that the pipeline resource has description property? I think we don't support it. |
@@ -106,6 +106,10 @@ func resourcePipeline() *schema.Resource { | |||
Optional: true, | |||
Default: "github", | |||
}, | |||
"description": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Event if we supported this field for the pipeline, why do you put in spec_template
?
`, rName, repo, path, revision, context, description) | ||
} | ||
|
||
func TestAccCodefreshPipeline_Description(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this test is valid? You just added the description property under the spec_template
and here you are specifying it under the spec
Discard the comment above please, there was a thing that confused me. We support it indeed. I think it will be better to put |
Fixes #70
Added
description
field to spec to match the API spec for the pipeline resource.