Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Data source project #117

Conversation

Jake-Mok-Nelson
Copy link
Contributor

@Jake-Mok-Nelson Jake-Mok-Nelson commented May 8, 2023

What

Create a project data resource for the Terraform Codefresh provider

Fixes #116

Why

A project data resource would allow us to perform validation before allowing a pipeline to target a project that may or may not exist. Ordinarily you'd just target the project resource but pipelines are not always created in the same location as the projects.

Notes

I have no ability to test this at the moment (I do not have connectivity to a Codefresh system), I'm hoping you can validate that it's good.

Checklist

Sorry, something went wrong.

@Jake-Mok-Nelson Jake-Mok-Nelson marked this pull request as ready for review May 8, 2023 08:50
@korenyoni
Copy link
Contributor

/test

@korenyoni
Copy link
Contributor

Sorry for the delay and thanks for the contribution.

I will have to take over the branch, add some tests and also run make docs. I will see if I can get to it next week.

@ilia-medvedev-codefresh
Copy link
Contributor

@Jake-Mok-Nelson I will be taking over this PR, will try to get it merged this week. Pushed some changes to your branch (merged from our upstream and added docs)

@ilia-medvedev-codefresh
Copy link
Contributor

/test

1 similar comment
@ilia-medvedev-codefresh
Copy link
Contributor

/test

@ilia-medvedev-codefresh ilia-medvedev-codefresh changed the title Data source project Feat: Data source project Feb 25, 2024
@ilia-medvedev-codefresh ilia-medvedev-codefresh merged commit 353f7d9 into codefresh-io:master Feb 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Project Data Source
3 participants