Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dind-rootless): remove symlink #71

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

mikhail-klimko
Copy link
Contributor

@mikhail-klimko mikhail-klimko commented Nov 13, 2024

What

Remove symlink /var/run -> /run/user/1000

Why

We have an option in cf-runtime helm chart to override docker daemon.json config instead

  runtime:
    dindDaemon:
      hosts:
        - unix:///run/user/1000/docker.sock
        - tcp://0.0.0.0:1300

Notes

Labels

Assign the following labels to the PR:

security - to trigger image scanning in CI build

PR Comments

Add the following comments to the PR:

/e2e - to trigger E2E build

@mikhail-klimko mikhail-klimko changed the title Cr 19993 rootless permissions fix(dind-rootless): remove symlink Nov 14, 2024
@mikhail-klimko
Copy link
Contributor Author

/e2e

@mikhail-klimko
Copy link
Contributor Author

/e2e

@mikhail-klimko mikhail-klimko marked this pull request as ready for review November 14, 2024 11:10
@mikhail-klimko mikhail-klimko merged commit 5dc5bb7 into rootless Nov 14, 2024
2 checks passed
@mikhail-klimko mikhail-klimko deleted the cr-19993-rootless-permissions branch November 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants