escape , from env var value (#589)

codefresh-io · Nov 15, 2020 · 4a08b39 · 4a08b39
1 parent 9f17f57
commit 4a08b39
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/lib/interface/cli/commands/hybrid/helper.js b/lib/interface/cli/commands/hybrid/helper.js
@@ -462,7 +462,7 @@ async function runClusterAcceptanceTests({
     if (envVars) {
         envVars.forEach((item) => {
             const parts = item.split('=');
-            cmd.push(`--set-value=EnvVars.${parts[0]}=${parts[1]}`);
+            cmd.push(`--set-value=EnvVars.${parts[0]}=${parts[1].replace(/,/g, '\\,')}`);
         });
     }
     if (valuesFile) {
@@ -565,7 +565,7 @@ async function installAgent({
     if (envVars) {
         envVars.forEach((item) => {
             const parts = item.split('=');
-            cmd.push(`--set-value=EnvVars.${parts[0]}=${parts[1]}`);
+            cmd.push(`--set-value=EnvVars.${parts[0]}=${parts[1].replace(/,/g, '\\,')}`);
         });
     }
     if (valuesFile) {
@@ -641,7 +641,7 @@ async function installRuntime({
     if (envVars) {
         envVars.forEach((item) => {
             const parts = item.split('=');
-            cmd.push(`--set-value=EnvVars.${parts[0]}=${parts[1]}`);
+            cmd.push(`--set-value=EnvVars.${parts[0]}=${parts[1].replace(/,/g, '\\,')}`);
         });
     }
     if (setFile) {
@@ -719,7 +719,7 @@ async function installAppProxy({
     if (envVars) {
         envVars.forEach((item) => {
             const parts = item.split('=');
-            cmd.push(`--set-value=EnvVars.${parts[0]}=${parts[1]}`);
+            cmd.push(`--set-value=EnvVars.${parts[0]}=${parts[1].replace(/,/g, '\\,')}`);
         });
     }
     if (valuesFile) {

diff --git a/lib/interface/cli/commands/monitor/install.cmd.js b/lib/interface/cli/commands/monitor/install.cmd.js
@@ -121,7 +121,7 @@ const installMonitorCmd = new Command({
         if (envVars) {
             envVars.forEach((item) => {
                 const parts = item.split('=');
-                commands.push(`--set-value=EnvVars.${parts[0]}=${parts[1]}`);
+                commands.push(`--set-value=EnvVars.${parts[0]}=${parts[1].replace(/,/g, '\\,')}`);
             });
         }
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.73.19",
+  "version": "0.73.20",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,