remove redundant params (#464)

* remove redundant params
codefresh-io · May 19, 2020 · 2f807af · 2f807af
1 parent 25842a3
commit 2f807af
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 27 deletions.
diff --git a/lib/interface/cli/commands/hybrid/delete.cmd.js b/lib/interface/cli/commands/hybrid/delete.cmd.js
@@ -35,10 +35,10 @@ const deleteCmd = new Command({
             default: DEFAULTS.URL,
         })
         .option('kube-context-name', {
-            describe: 'Name of the kubernetes context on which venona should be installed [$CF_ARG_KUBE_CONTEXT_NAME]',
+            describe: 'Name of the kubernetes context from which the Codefresh Agent and Runtime should be removed',
         })
         .option('kube-namespace', {
-            describe: 'Name of the namespace on which venona should be installed [$CF_ARG_KUBE_NAMESPACE]',
+            describe: 'Name of the kubernetes namespace from which the Codefresh Agent and Runtime should be removed',
         })
         .option('kube-config-path', {
             describe: 'Path to kubeconfig file (default is $HOME/.kube/config)',

diff --git a/lib/interface/cli/commands/hybrid/init.cmd.js b/lib/interface/cli/commands/hybrid/init.cmd.js
@@ -168,9 +168,6 @@ const initCmd = new Command({
         .option('kube-node-selector', {
             describe: 'The kubernetes node selector "key=value" to be used by venona build resources (default is no node selector) (string)',
         })
-        .option('dry-run', {
-            describe: 'Set to true to simulate installation',
-        })
         .option('yes', {
             describe: 'Use installation defaults (don\'t ask any questions)',
             alias: 'y',
@@ -184,43 +181,26 @@ const initCmd = new Command({
             describe: 'Run a demo pipeline after the installation completes',
             type: 'boolean',
         })
-        .option('in-cluster', {
-            describe: 'Set flag if venona is been installed from inside a cluster',
-        })
         .option('kube-namespace', {
             describe: 'Name of the namespace on which venona should be installed [$CF_ARG_KUBE_NAMESPACE]',
         })
-        .option('kubernetes-runner-type', {
-            describe: 'Set the runner type to kubernetes (alpha feature)',
-        })
         .option('tolerations', {
             describe: 'The kubernetes tolerations as path to a  JSON file to be used by venona resources (default is no tolerations) (string)',
         })
         .option('storage-class-name', {
             describe: 'Set a name of your custom storage class',
         })
-        .option('venona-version', {
-            describe: 'Version of venona to install (default is the latest)',
-        })
         .option('kube-config-path', {
             describe: 'Path to kubeconfig file (default is $HOME/.kube/config)',
         })
-        .option('skip-version-check', {
-            describe: 'Do not compare current Venona\'s version with latest',
-        })
         .option('verbose', {
             describe: 'Print logs',
         }),
     handler: async (argv) => {
         const {
             'kube-node-selector': kubeNodeSelector,
-            'dry-run': dryRun,
-            'in-cluster': inCluster,
-            'kubernetes-runner-type': kubernetesRunnerType,
             tolerations,
-            'venona-version': venonaVersion,
             'kube-config-path': kubeConfigPath,
-            'skip-version-check': skipVersionCheck,
             'storage-class-name': storageClassName,
             yes: noQuestions,
             verbose,
@@ -341,14 +321,9 @@ const initCmd = new Command({
             name,
             'kube-context-name': kubeContextName,
             'kube-node-selector': kubeNodeSelector,
-            'dry-run': dryRun,
-            'in-cluster': inCluster,
             'kube-namespace': kubeNamespace,
-            'kubernetes-runner-type': kubernetesRunnerType,
             tolerations,
-            'venona-version': venonaVersion,
             'kube-config-path': kubeConfigPath,
-            'skip-version-check': skipVersionCheck,
             'install-runtime': true,
             verbose,
             'make-default-runtime': shouldMakeDefaultRe,

diff --git a/test-setup.js b/test-setup.js
@@ -22,6 +22,7 @@ global.verifyResponsesReturned = async (responses) => {
 global.configureSdk = async () => {
     if (!SDK_CONFIGURED) {
         SDK_CONFIGURED = true;
+        Object.keys(sdk).forEach(key => delete sdk[key]);
         sdk.configure(await Config.load({
             url: 'http://not.needed',
             apiKey: 'not-needed',