fix: CR-22222 analysis fix #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… promote action being called. Fixes argoproj#3220 (argoproj#3221) * fix: canary step analysis run wasn't terminated as keep running after promote action being called Signed-off-by: oleksandr-codefresh <[email protected]> * fix unit test: added test case for canary step analysis run wasn't terminated as keep running after promote action being called Signed-off-by: oleksandr-codefresh <[email protected]> --------- Signed-off-by: oleksandr-codefresh <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> (cherry picked from commit 0300af1)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.6 #300 +/- ##
===============================================
+ Coverage 81.68% 81.70% +0.01%
===============================================
Files 134 134
Lines 20496 20498 +2
===============================================
+ Hits 16742 16747 +5
+ Misses 2886 2883 -3
Partials 868 868 ☔ View full report in Codecov by Sentry. |
Go Published Test Results2 066 tests 2 066 ✅ 2m 47s ⏱️ Results for commit ef75a53. |
denis-codefresh
approved these changes
Jan 18, 2024
pasha-codefresh
approved these changes
Jan 18, 2024
E2E Tests Published Test Results 4 files 4 suites 3h 26m 39s ⏱️ For more details on these failures, see this check. Results for commit ef75a53. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked fix from upstream - argoproj#3221
Checklist:
"fix(controller): Updates such and such. Fixes #1234".