Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: argo-cd 2.12 #328

Merged
merged 684 commits into from
Sep 3, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
684 commits
Select commit Hold shift + click to select a range
257b242
add apiVersion so yaml applies properly in-cluster (#18282)
condaatje May 20, 2024
4d61974
fix(ui): Add title for full content without clicking (issue #17600) (…
sunyeongchoi May 20, 2024
9c8d652
feat: Adding the domain_hint as an optional field in OIDC configurati…
nikzayn May 20, 2024
8480f5c
chore(deps): bump library/node from 21.6.2 to 21.7.0 (#17446)
dependabot[bot] May 20, 2024
4f66669
chore(ci): add /ui-test/ directory to dependabot.yml (#16235)
chengfang May 20, 2024
95d37dc
fix(deps): upgrade otel dependency (#18285)
34fathombelow May 20, 2024
3c19fdb
chore(deps-dev): bump typescript from 4.1.3 to 5.4.5 in /ui-test (#18…
dependabot[bot] May 20, 2024
90df1e6
chore(deps-dev): bump prettier from 1.19.1 to 2.8.8 in /ui-test (#18302)
dependabot[bot] May 20, 2024
ddc8523
chore(deps): bump library/node from 21.7.0 to 22.2.0 (#18297)
dependabot[bot] May 20, 2024
aa7f1c5
chore: update jest version (#18295)
pasha-codefresh May 20, 2024
b447dcc
chore(deps): bump chromedriver from 94.0.0 to 125.0.0 in /ui-test (#1…
dependabot[bot] May 20, 2024
5d31b03
chore(deps): bump gitpod/workspace-full from `511cecd` to `f569b00` (…
dependabot[bot] May 21, 2024
d1135c1
chore(deps-dev): bump dotenv from 8.2.0 to 16.4.5 in /ui-test (#18298)
dependabot[bot] May 21, 2024
4c754c8
docs(webhook): include installation instructions on Triggers and Temp…
briceburg May 21, 2024
36b8ff5
--- (#18312)
dependabot[bot] May 21, 2024
6374331
--- (#18311)
dependabot[bot] May 21, 2024
e34aa2f
--- (#18315)
dependabot[bot] May 21, 2024
fda368b
chore(deps-dev): bump @types/node from 14.14.14 to 20.12.12 in /ui-te…
dependabot[bot] May 21, 2024
441367f
--- (#18307)
dependabot[bot] May 21, 2024
43cb800
add fullscreen prop (#18309)
Fluder-Paradyne May 21, 2024
e096817
--- (#18314)
dependabot[bot] May 21, 2024
f138617
feat: Implement KafkaConnector,KafkaBridge CRD health checks (#18316)
lenglet-k May 21, 2024
2dd5cd8
--- (#18318)
dependabot[bot] May 21, 2024
13d5803
Merge pull request from GHSA-9766-5277-j5hr
mayzhang2000 May 21, 2024
8dff209
Merge pull request from GHSA-9766-5277-j5hr
mayzhang2000 May 21, 2024
78e0fc4
docs: redis-ha registry change (#18329)
crenshaw-dev May 21, 2024
1453dc4
fix(ci): codecov (#18335)
crenshaw-dev May 21, 2024
bc53266
chore(deps): bump golangci/golangci-lint-action from v3.7.0 to 6.0.1 …
crenshaw-dev May 21, 2024
462c9ec
fix(ui): Fix jumpy "Source" panel when typing (issue #15961) (#18227)
david-wu-octopus May 22, 2024
6110581
Update docs for azure workload identity cluster setup (#18357)
MarkTallentire May 22, 2024
4aa6269
--- (#18353)
dependabot[bot] May 22, 2024
0ec7f82
--- (#18349)
dependabot[bot] May 22, 2024
cef69c3
--- (#18345)
dependabot[bot] May 22, 2024
96c2a95
--- (#18346)
dependabot[bot] May 22, 2024
bd671e8
chore(deps): bump golang.org/x/net from v0.21.0 to v0.25.0 (#18176)
crenshaw-dev May 22, 2024
6a68b95
--- (#18352)
dependabot[bot] May 22, 2024
4606476
--- (#18313)
dependabot[bot] May 22, 2024
59ce337
fix: app names with non-alphanumeric characters in position 63 break …
RobinsonZ May 22, 2024
ee9b38f
feat: add ls-remote request fail metric (#18250)
Jack-R-lantern May 22, 2024
00672a8
docs: Clarify how Argo CD detects and uses Kustomize (#11417)
mcgitty May 22, 2024
cd14356
removing strikeout as it was populating special character issue #141…
rkriplani76 May 22, 2024
22a3a68
docs: Remove special characters from update doc (#18363)
todaywasawesome May 22, 2024
8776cc1
--- (#18362)
dependabot[bot] May 22, 2024
52acbd5
[Bot] docs: Update Snyk reports (#18365)
github-actions[bot] May 22, 2024
d73eb8f
fix: remove Egress NetworkPolicy for argocd-redis and argocd-redis-ha…
mayzhang2000 May 22, 2024
600737a
feat: Added the comment to support CLI message to get extended output…
nikzayn May 23, 2024
37900ee
chore(deps-dev): bump @types/react-paginate from 6.2.1 to 7.1.4 in /u…
dependabot[bot] May 23, 2024
9f27197
chore(deps): bump chromedriver from 125.0.0 to 125.0.1 in /ui-test (#…
dependabot[bot] May 23, 2024
049900e
chore: automate mock generation v2 (#18371)
blakepettersson May 23, 2024
5452bf1
chore(deps): bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (#18182)
dependabot[bot] May 23, 2024
781261a
chore(deps-dev): bump @types/react-autocomplete in /ui (#18374)
dependabot[bot] May 23, 2024
45832ce
chore(deps): bump @types/superagent from 4.1.21 to 8.1.6 in /ui (#17606)
dependabot[bot] May 23, 2024
a95d595
chore(deps): bump goreleaser/goreleaser-action from 5.0.0 to 5.1.0 (#…
dependabot[bot] May 23, 2024
97648ee
fixes list generator cluster element (#18389)
RafaelBroseghini May 23, 2024
1432f11
chore(deps): bump chromedriver from 125.0.1 to 125.0.2 in /ui-test (#…
dependabot[bot] May 24, 2024
d871b7f
fix source ordering issue in manifest generation for multi-source app…
ishitasequeira May 24, 2024
cd3c478
ci(lint): create .golangci.yaml (#18410)
mmorel-35 May 25, 2024
8f02ec1
[Bot] docs: Update Snyk reports (#18413)
github-actions[bot] May 27, 2024
8a28279
chore(deps): bump library/redis in /test/container (#18421)
dependabot[bot] May 27, 2024
9fe1dbf
fix: enable misspell linter (#18412)
mmorel-35 May 28, 2024
dd3bb2b
fix: repo-server should allow not to skip hidden directories (#17957)
BarAshkenazi May 28, 2024
21b1514
chore(deps): bump docker/login-action from 3.1.0 to 3.2.0 (#18440)
dependabot[bot] May 29, 2024
a36f50f
docs: Fix "core" link in getting started (#18437)
erpel May 29, 2024
ef9de40
feat(ui): list dependent resources in delete popup (#18116)
agaudreault May 29, 2024
55416ad
chore(deps): bump @fortawesome/fontawesome-free in /ui (#18397)
dependabot[bot] May 29, 2024
2d2fb08
Update ingress.md (#17766)
sakirma May 30, 2024
807754c
chore(deps-dev): bump sass-loader from 12.6.0 to 14.2.1 in /ui (#18451)
dependabot[bot] May 30, 2024
ced9a4a
chore(deps-dev): bump @types/node from 20.12.12 to 20.12.13 in /ui-te…
dependabot[bot] May 30, 2024
e3dff07
chore(deps-dev): bump monaco-editor-webpack-plugin in /ui (#18450)
dependabot[bot] May 30, 2024
4d8436b
feat: removed legacy app tracking label (#13203)
gdsoumya May 30, 2024
1e2f598
feat(issue/#17003): implement camel.apache.org/Integration CRD health…
mdebarros May 30, 2024
7ccf826
feat: Kyriba is using ArgoCD (#18456)
nabilbendafi May 30, 2024
7acd9f0
docs: remove the recommendation to optionally auth redis for secrets …
tico24 May 30, 2024
1450f10
chore: add pipekit to argocd USERS (#18457)
tico24 May 30, 2024
ef37b39
Revert "feat(server): log app Spec along with event (#16416)" (#18458)
jannfis May 30, 2024
4fda009
chore(deps): bump foundation-sites from 6.7.5 to 6.8.1 in /ui (#18462)
dependabot[bot] May 31, 2024
85ed1b9
fix: Update braces package to 3.0.3 (#18459)
keithchong Jun 2, 2024
2639c59
chore: use redis secret when running locally (#18489)
crenshaw-dev Jun 3, 2024
1f0c658
chore(deps): bump library/busybox in /test/e2e/multiarch-container (#…
dependabot[bot] Jun 4, 2024
d90cfaf
docs: fix indentation (#18494)
sathieu Jun 4, 2024
d959a68
chore(deps-dev): bump @types/node from 20.12.13 to 20.14.1 in /ui-tes…
dependabot[bot] Jun 4, 2024
c1960b5
chore(deps): bump @types/selenium-webdriver in /ui-test (#18476)
dependabot[bot] Jun 4, 2024
6f43b68
chore(deps): bump chromedriver from 125.0.2 to 125.0.3 in /ui-test (#…
dependabot[bot] Jun 4, 2024
f19825e
[Bot] docs: Update Snyk reports (#18471)
github-actions[bot] Jun 4, 2024
c99fd49
feat: argocd cli support fish completion (#18484)
Sn0rt Jun 4, 2024
3703a1e
fix: prevent preview changes sync (#18400)
yyzxw Jun 5, 2024
69e82cc
chore: allow override of default e2e test args (#18415)
aslafy-z Jun 5, 2024
05576fd
chore(deps): bump goreleaser/goreleaser-action from 5.1.0 to 6.0.0 (#…
dependabot[bot] Jun 5, 2024
ea909fe
Update ingress.md (#18491)
zencircle Jun 5, 2024
75cd97d
feat: Consistent hashing with bounded loads algorithm for sharding (#…
akram Jun 5, 2024
71e1f30
fix: enable bool-compare rule from testifylint linter (#18414)
mmorel-35 Jun 5, 2024
175d7ee
docs: proposal for enhancing scoped repository credentials (#18290)
blakepettersson Jun 5, 2024
e54e45e
feat: changes git client to resolve semantic versioning tags (#17566)
thepabloaguilar Jun 6, 2024
92b22fd
Move code around to fix commit attribution. (#18515)
PaulSonOfLars Jun 6, 2024
240c008
chore(deps-dev): bump @types/node from 20.14.1 to 20.14.2 in /ui-test…
dependabot[bot] Jun 6, 2024
362b821
chore(deps): bump bitnami/kubectl in /test/container (#18517)
dependabot[bot] Jun 6, 2024
60cdd7d
docs: update notifications troubleshooting-errors doc with custom sec…
hawkesn Jun 6, 2024
256d901
Merge pull request from GHSA-87p9-x75h-p4j2
blakepettersson Jun 6, 2024
c264705
Merge pull request from GHSA-3cqf-953p-h5cp
pasha-codefresh Jun 6, 2024
8107303
fix(applicationset): prevent applicationset progressive sync from sta…
wparr-circle Jun 6, 2024
2077688
test: fix e2e tests after GHSA-3cqf-953p-h5cp (#18543)
crenshaw-dev Jun 6, 2024
d2fddb8
fix: github.com/cloudflare/circl High CVE (#18538)
34fathombelow Jun 7, 2024
37238ab
chore: bump go version to 1.22.4 (#18539)
34fathombelow Jun 7, 2024
c4756c5
fix(ci): run codegen for docs changes (#18536)
crenshaw-dev Jun 7, 2024
50745f0
chore(deps): upgrade helm to 5.4.2 (#18556)
34fathombelow Jun 7, 2024
44b8dc1
chore: enable len and empty rules from testifylint linter (#18516)
mmorel-35 Jun 7, 2024
4fd478b
feat: project-scoped repository credential improvements (#18388)
blakepettersson Jun 8, 2024
1d83e65
[Bot] docs: Update Snyk reports (#18561)
github-actions[bot] Jun 10, 2024
33df2ce
chore: enable goimports linter (#18564)
mmorel-35 Jun 10, 2024
0d153ef
chore: enable errorlint linter on `pkg` folder (#18563)
mmorel-35 Jun 10, 2024
32519c7
chore: enable error-nil rule from testifylint linter (#18544)
mmorel-35 Jun 10, 2024
2547abc
fix: sonar scanner #18513 (#18559)
rumstead Jun 10, 2024
45d6842
fix: InferenceService healthy condition change (#18340)
bmopuri Jun 10, 2024
020881a
chore(deps): upgrade haproxy to 2.6.17-alpine (#18574)
34fathombelow Jun 10, 2024
879cc60
chore(ci): ignore test files from sonar monitoring (#18573)
crenshaw-dev Jun 10, 2024
772c316
chore: enable errorlint linter on `cmd` folder (#18578)
mmorel-35 Jun 10, 2024
4a01f8a
chore: enable expected-actual rule from testifylint linter (#18575)
mmorel-35 Jun 10, 2024
d8c8300
chore: add sonar-project.properties to cd in CODEOWNERS (#18577)
crenshaw-dev Jun 10, 2024
0e531c9
feat(application-controller): Add support for rollback multi-source a…
JorTurFer Jun 10, 2024
355ec75
chore(deps): bump docker/build-push-action from 5.3.0 to 5.4.0 (#18583)
dependabot[bot] Jun 11, 2024
d7e9922
chore: enable errorlint linter on util folder (#18588)
mmorel-35 Jun 11, 2024
7cf5ed0
chore: enable gofumpt and whitespace linters (#18567)
mmorel-35 Jun 11, 2024
3160369
chore: enable compare and nil-compare rules from testifylint linter (…
mmorel-35 Jun 11, 2024
140f172
chore: enable errorlint linter on controller folder (#18596)
mmorel-35 Jun 11, 2024
3e2cfb1
docs: Add Syself to USERS.md (#18593)
janiskemper Jun 11, 2024
48bdf94
feat(appset): appset git generator verifies GPG signatures (#18545)
ishitasequeira Jun 12, 2024
2c53258
chore(deps): bump library/node from 22.2.0 to 22.3.0 in /ui-test (#18…
dependabot[bot] Jun 12, 2024
6c1f0f8
chore(deps): bump library/node from 22.2.0 to 22.3.0 in /test/contain…
dependabot[bot] Jun 12, 2024
33df5ac
chore(deps): bump library/node from 22.2.0 to 22.3.0 (#18611)
dependabot[bot] Jun 12, 2024
8f280cf
chore(deps): bump braces from 3.0.2 to 3.0.3 in /ui-test (#18584)
dependabot[bot] Jun 12, 2024
74a420d
fix(ui): pod log view dark mode toggle (#18424)
surajyadav1108 Jun 12, 2024
204176a
chore: enable errorlint linter on applicationset folder (#18618)
mmorel-35 Jun 12, 2024
f1848f5
chore: enable errorlint linter on server folder (#18624)
mmorel-35 Jun 12, 2024
311c059
chore: enable require-error rule from testifylint linter (#18621)
mmorel-35 Jun 13, 2024
f7341ae
chore: enable errorlint linter on cmpserver and reposerver folders (#…
mmorel-35 Jun 13, 2024
fba3c2e
chore(deps): bump library/golang from `969349b` to `0f76912` (#18628)
dependabot[bot] Jun 13, 2024
6232d73
chore(deps): bump bitnami/kubectl in /test/container (#18626)
dependabot[bot] Jun 13, 2024
6f76e71
chore(deps): bump chromedriver from 125.0.3 to 126.0.0 in /ui-test (#…
dependabot[bot] Jun 13, 2024
7adec6e
ci: updated yarn version (#18631)
blakepettersson Jun 13, 2024
9bc1578
feat: Support Rollback multi-source apps; Follow-up to PR 14124 (#18615)
keithchong Jun 13, 2024
2040bd6
fix: Correction in Rocket.chat documentation (#18498)
raghavi101 Jun 13, 2024
5efa404
chore(deps): bump library/golang in /test/container (#18625)
dependabot[bot] Jun 13, 2024
9592b84
feat: adding gocover to e2e tests (#18130) (#18537)
rumstead Jun 13, 2024
9f1e2e8
chore: enable gocritic linter (#18633)
mmorel-35 Jun 13, 2024
ae61752
feat: Provide Edit support in Sources tab for multi-source app (#1758…
keithchong Jun 14, 2024
7efde25
docs: update multiple sources docs (#18662)
ishitasequeira Jun 14, 2024
1757b7e
chore(deps): bump SonarSource/sonarqube-scan-action from 2.1.0 to 2.2…
dependabot[bot] Jun 14, 2024
f8557d2
chore(deps): bump codecov/codecov-action from 4.4.1 to 4.5.0 (#18650)
dependabot[bot] Jun 14, 2024
c9ea5b1
chore: extend require-error rule from testifylint (#18658)
mmorel-35 Jun 14, 2024
e025194
fix: minor ui fixes for repositories (#18648)
blakepettersson Jun 14, 2024
03e6f8a
chore: update docs and skip gpg tests on appset (#18637)
ishitasequeira Jun 14, 2024
48eb7f3
docs: Improve the FAQ (#12039) (#18645)
jsoref Jun 14, 2024
2d5c59c
fix(ui): dropdown-fixed in logs (#18470)
surajyadav1108 Jun 14, 2024
1405413
chore(deps): bump library/node from `f73cc32` to `5e4044f` in /ui-tes…
dependabot[bot] Jun 14, 2024
57ee536
chore(deps): bump library/node from `f73cc32` to `5e4044f` (#18654)
dependabot[bot] Jun 14, 2024
5796557
chore(deps): bump library/node in /test/container (#18651)
dependabot[bot] Jun 14, 2024
170d543
chore(deps): bump library/golang from `0f76912` to `a1dc408` (#18674)
crenshaw-dev Jun 14, 2024
2c0cc02
docs(cli): remove docs for non-existing `argocd app set` flags (#1867…
crenshaw-dev Jun 14, 2024
0d1d1a1
chore: extend require-error rule from testifylint (#18675)
mmorel-35 Jun 14, 2024
cc700df
chore(ci): only test four latest k8s versions (#18676)
crenshaw-dev Jun 14, 2024
e3fa52d
chore: bump version (#18677)
crenshaw-dev Jun 15, 2024
eac08dc
chore: extend require-error rule from testifylint (#18681)
mmorel-35 Jun 15, 2024
38d6db6
chore: enable require-error rule from errorlint linter on cmd folder …
mmorel-35 Jun 15, 2024
ad461c2
chore(deps): bump Kustomize from 3.14.4 to 3.15.2 (#18680)
crenshaw-dev Jun 15, 2024
f770a2a
chore: enable require-error rule from errorlint linter on test folder…
mmorel-35 Jun 15, 2024
1ecd397
chore: ignore mocks in codecov (#18685)
crenshaw-dev Jun 15, 2024
dbb9bc8
chore: add codecov config to CI approvers (#18686)
crenshaw-dev Jun 15, 2024
336cc29
feat(reposerver): Skip calling git fetch if commit to checkout exists…
shady-canva Jun 15, 2024
2aefa9c
chore(deps): bump gitops engine (#18679)
crenshaw-dev Jun 15, 2024
c556cf7
chore: enable require-error rule from errorlint linter on server fold…
mmorel-35 Jun 15, 2024
b3b090b
[Bot] docs: Update Snyk reports (#18692)
github-actions[bot] Jun 16, 2024
52b1b43
chore(deps): bump tj-actions/changed-files from 42.0.2 to 44.5.2 (#18…
dependabot[bot] Jun 16, 2024
130c0f4
chore: missing qtar in go exclusions (#18698)
mmorel-35 Jun 16, 2024
d57800f
chore(deps): bump chromedriver from 126.0.0 to 126.0.1 in /ui-test (#…
dependabot[bot] Jun 17, 2024
1fd2f62
chore(deps): bump library/redis in /test/container (#18652)
dependabot[bot] Jun 17, 2024
af60215
chore(deps): bump library/golang in /test/container (#18653)
dependabot[bot] Jun 17, 2024
e5c0526
chore(deps): bump library/golang from `0f76912` to `a1dc408` (#18655)
dependabot[bot] Jun 17, 2024
89a0cc3
chore: enable require-error rule from errorlint linter on pkg folder …
mmorel-35 Jun 17, 2024
4494fe5
chore: enable require-error rule from errorlint linter on application…
mmorel-35 Jun 17, 2024
d7fc1bf
chore: enable require-error rule from errorlint linter on controller …
mmorel-35 Jun 17, 2024
4c6ad9d
feat: Add labels on Application's k8s events (#11381) (#18160)
svghadi Jun 17, 2024
8f28199
chore: enable require-error from testifylint on cmpserver and reposer…
mmorel-35 Jun 18, 2024
9f0d2a8
fix: docs site version selector broken (#18378)
yyzxw Jun 18, 2024
f8e2ca7
fix: JSON unmarshaling error handling and nil return (#18700)
Yuni-sa Jun 18, 2024
50f889c
chore(deps): bump library/golang from `4950c1c` to `c2010b9` (#18704)
dependabot[bot] Jun 18, 2024
3fb9d95
chore(deps-dev): bump @types/node from 20.14.2 to 20.14.4 in /ui-test…
dependabot[bot] Jun 18, 2024
e5eddc3
chore(deps): bump library/golang in /test/container (#18706)
dependabot[bot] Jun 18, 2024
fe965ed
chore(deps): bump library/redis in /test/container (#18707)
dependabot[bot] Jun 18, 2024
3f0d8d5
chore(deps): bump ws from 8.17.0 to 8.17.1 in /ui (#18712)
dependabot[bot] Jun 18, 2024
029b5ac
chore(deps): bump ws from 8.17.0 to 8.17.1 in /ui-test (#18711)
dependabot[bot] Jun 18, 2024
fe60670
Bump version to 2.12.0-rc1 (#18716)
github-actions[bot] Jun 18, 2024
2a9a62e
fix(ui): set project to empty string if undefined (#18732) (#18733)
gcp-cherry-pick-bot[bot] Jun 20, 2024
16c20a8
fix(server): could not find source for metadata revision (#18744) (#1…
gcp-cherry-pick-bot[bot] Jun 24, 2024
00fc93b
fix: Bug in edit support in Sources tab; Input to loader (#17588) (#1…
gcp-cherry-pick-bot[bot] Jun 24, 2024
bbfa79a
Bump version to 2.12.0-rc2 (#18802)
github-actions[bot] Jun 24, 2024
e36e19d
chore(deps): bump github.com/hashicorp/go-retryablehttp (#18805) (#18…
gcp-cherry-pick-bot[bot] Jun 25, 2024
e616dff
fix(appset): revert "keep reconciling even when params error occurre…
crenshaw-dev Jun 25, 2024
573c771
fix(webhook): bitbucket and azure not triggering refresh (#18289) (#1…
gcp-cherry-pick-bot[bot] Jun 26, 2024
444d332
fix: Handle nil health check in post-delete hooks (#18270) (#18767) (…
gcp-cherry-pick-bot[bot] Jun 26, 2024
50c32b5
docs: Fix .path to .path.segments go template (#18872) (#18873)
gcp-cherry-pick-bot[bot] Jul 1, 2024
b211d3e
chore: bump gitops-engine (#18871)
crenshaw-dev Jul 1, 2024
1237d4e
Bump version to 2.12.0-rc3 (#18893)
github-actions[bot] Jul 2, 2024
81d4542
remove unwanted updating of source-position in app set command (#1888…
gcp-cherry-pick-bot[bot] Jul 2, 2024
beacacc
fix(appset): missing permissions (#18829) (#18943) (#18944)
gcp-cherry-pick-bot[bot] Jul 4, 2024
065f849
fix(cli): Get Redis password from secret in `loadClusters()` (#18951)…
gcp-cherry-pick-bot[bot] Jul 5, 2024
511d6e3
chore: bump gitops-engine (#19056)
agaudreault Jul 15, 2024
0704aa6
Bump version to 2.12.0-rc4 (#19060)
github-actions[bot] Jul 15, 2024
cec8504
fix: cherry-pick #18761 (v2.12) (#19109)
blakepettersson Jul 19, 2024
d926310
chore: revert "feat: removed legacy app tracking label (#13203)" (che…
gcp-cherry-pick-bot[bot] Jul 24, 2024
004cabb
fix(applicationset): ensure that older applicationStatus is updated w…
gcp-cherry-pick-bot[bot] Jul 25, 2024
eaa1972
feat: webhook ddos -2.12 (#19329)
pasha-codefresh Jul 31, 2024
d6c37aa
Merge commit from fork (#19330)
pasha-codefresh Jul 31, 2024
dee59f3
feat(rbac): allow validation of fine-grained policy in project (#1933…
gcp-cherry-pick-bot[bot] Aug 1, 2024
3e31ce9
fix: ArgoCD 2.11 - Loop of PATCH calls to Application objects (#19340…
gcp-cherry-pick-bot[bot] Aug 1, 2024
6f2ae0d
Bump version to 2.12.0-rc5 (#19349)
github-actions[bot] Aug 1, 2024
57e61b2
feat: Add custom health check for cluster-api AWSManagedControlPlane …
gcp-cherry-pick-bot[bot] Aug 2, 2024
ec30a48
Bump version to 2.12.0 (#19383)
github-actions[bot] Aug 5, 2024
fd47845
fix: docs version regex changed (#18756) (#19352)
ft-jasong Aug 8, 2024
b156b61
fix(appset): missing permissions for cluster install (#19059) (#19430…
gcp-cherry-pick-bot[bot] Aug 8, 2024
7af4526
fix: appset gpg limitation for templated project fields (#19492) (#19…
gcp-cherry-pick-bot[bot] Aug 14, 2024
952838c
fix(appset): cherry-pick - fix appset-in-any-namespace issue with git…
ishitasequeira Aug 15, 2024
b0d08c1
lint fix
oleksandr-codefresh Aug 16, 2024
26b2039
Bump version to 2.12.1 (#19568)
github-actions[bot] Aug 16, 2024
f319a61
Merge branch 'refs/heads/2.12-upstream' into CR-24727-argo-cd-2-12
oleksandr-codefresh Aug 19, 2024
119dccc
go mod tidy
oleksandr-codefresh Aug 20, 2024
129785b
protogen & gogen after 2.12 merge
oleksandr-codefresh Aug 20, 2024
88f85da
fix: Parse hostname correctly from repoURL to fetch correct CA cert (…
gcp-cherry-pick-bot[bot] Aug 21, 2024
c873d5c
fix: Floating title content incorrect for multi-sources (#17274) (#19…
gcp-cherry-pick-bot[bot] Aug 21, 2024
b068220
fix(appset): informer is not a kubernetes informer (#18905) (#19618) …
gcp-cherry-pick-bot[bot] Aug 22, 2024
7244c2d
fix(appset): remove cache references (#19652)
rumstead Aug 22, 2024
560953c
Bump version to 2.12.2 (#19657)
github-actions[bot] Aug 23, 2024
93d8cf6
lint fix
oleksandr-codefresh Aug 23, 2024
f5fceee
codegen
oleksandr-codefresh Aug 23, 2024
a65706c
fix unit tests
oleksandr-codefresh Aug 23, 2024
efb4189
fix ci
oleksandr-codefresh Aug 23, 2024
343dec0
feat(sourceNamespace): Regex Support (#19016) (#19017) (#19664)
gcp-cherry-pick-bot[bot] Aug 23, 2024
e4a70d3
remove e2e coverage testing
oleksandr-codefresh Aug 23, 2024
bf096b8
delete v2
oleksandr-codefresh Aug 23, 2024
9b2f784
remove `combine-go-coverage` from ci
oleksandr-codefresh Aug 23, 2024
cedefd2
go gen fix
oleksandr-codefresh Aug 23, 2024
cafd35c
fix(AnyNameSpaceRegex): Additional Functions Glob to Regexexp (#19516…
gcp-cherry-pick-bot[bot] Aug 23, 2024
6b9cd82
Bump version to 2.12.3 (#19694)
github-actions[bot] Aug 27, 2024
191e2e2
improve logs
pasha-codefresh Aug 19, 2024
8f1af53
Merge branch 'refs/heads/upstream-2.12.3' into CR-24727-argo-cd-2-12
oleksandr-codefresh Aug 28, 2024
8c1a7db
codegen
oleksandr-codefresh Aug 28, 2024
0f243d5
ignore rev cache during manifest generation (#329)
pasha-codefresh Aug 27, 2024
69c1856
ignore rev cache during manifest generation
pasha-codefresh Aug 28, 2024
d9d02b2
respect rev cache during manifest generation
pasha-codefresh Aug 29, 2024
882c5cd
updated changelog message
oleksandr-codefresh Sep 3, 2024
9e32c5e
lint code
oleksandr-codefresh Sep 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: enable expected-actual rule from testifylint linter (argoproj#…
…18575)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
  • Loading branch information
mmorel-35 authored Jun 10, 2024
commit 4a01f8a69af222779665f7602aabf9f27f7b5e00
1 change: 0 additions & 1 deletion .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ linters-settings:
disable:
- compares
- error-is-as
- expected-actual
- float-compare
- go-require
- nil-compare
Expand Down
16 changes: 8 additions & 8 deletions applicationset/controllers/applicationset_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2482,7 +2482,7 @@ func TestReconcilerValidationProjectErrorBehaviour(t *testing.T) {
// make sure good app got created
err = r.Client.Get(context.TODO(), crtclient.ObjectKey{Namespace: "argocd", Name: "good-project"}, &app)
assert.NoError(t, err)
assert.Equal(t, app.Name, "good-project")
assert.Equal(t, "good-project", app.Name)

// make sure bad app was not created
err = r.Client.Get(context.TODO(), crtclient.ObjectKey{Namespace: "argocd", Name: "bad-project"}, &app)
Expand Down Expand Up @@ -2571,7 +2571,7 @@ func TestReconcilerCreateAppsRecoveringRenderError(t *testing.T) {
// make sure good app got created
err = r.Client.Get(context.TODO(), crtclient.ObjectKey{Namespace: "argocd", Name: "app"}, &app)
assert.NoError(t, err)
assert.Equal(t, app.Name, "app")
assert.Equal(t, "app", app.Name)
}

func TestSetApplicationSetStatusCondition(t *testing.T) {
Expand Down Expand Up @@ -2720,7 +2720,7 @@ func applicationsUpdateSyncPolicyTest(t *testing.T, applicationsSyncPolicy v1alp
// make sure good app got created
err = r.Client.Get(context.TODO(), crtclient.ObjectKey{Namespace: "argocd", Name: "good-cluster"}, &app)
assert.NoError(t, err)
assert.Equal(t, app.Name, "good-cluster")
assert.Equal(t, "good-cluster", app.Name)

// Update resource
var retrievedApplicationSet v1alpha1.ApplicationSet
Expand All @@ -2743,7 +2743,7 @@ func applicationsUpdateSyncPolicyTest(t *testing.T, applicationsSyncPolicy v1alp
err = r.Client.Get(context.TODO(), crtclient.ObjectKey{Namespace: "argocd", Name: "good-cluster"}, &app)
assert.NoError(t, err)
assert.True(t, resUpdate.RequeueAfter == 0)
assert.Equal(t, app.Name, "good-cluster")
assert.Equal(t, "good-cluster", app.Name)

return app
}
Expand Down Expand Up @@ -2890,7 +2890,7 @@ func applicationsDeleteSyncPolicyTest(t *testing.T, applicationsSyncPolicy v1alp
// make sure good app got created
err = r.Client.Get(context.TODO(), crtclient.ObjectKey{Namespace: "argocd", Name: "good-cluster"}, &app)
assert.NoError(t, err)
assert.Equal(t, app.Name, "good-cluster")
assert.Equal(t, "good-cluster", app.Name)

// Update resource
var retrievedApplicationSet v1alpha1.ApplicationSet
Expand Down Expand Up @@ -3203,7 +3203,7 @@ func TestPolicies(t *testing.T) {
var app v1alpha1.Application
err = r.Client.Get(context.TODO(), crtclient.ObjectKey{Namespace: "argocd", Name: "my-app"}, &app)
assert.NoError(t, err)
assert.Equal(t, app.Annotations["key"], "value")
assert.Equal(t, "value", app.Annotations["key"])

// Check if Application is updated
app.Annotations["key"] = "edited"
Expand All @@ -3218,9 +3218,9 @@ func TestPolicies(t *testing.T) {
assert.NoError(t, err)

if c.allowedUpdate {
assert.Equal(t, app.Annotations["key"], "value")
assert.Equal(t, "value", app.Annotations["key"])
} else {
assert.Equal(t, app.Annotations["key"], "edited")
assert.Equal(t, "edited", app.Annotations["key"])
}

// Check if Application is deleted
Expand Down
4 changes: 2 additions & 2 deletions applicationset/services/internal/http/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ func TestClientDo(t *testing.T) {
if cc.expectedError != nil {
assert.EqualError(t, err, cc.expectedError.Error())
} else {
assert.Equal(t, resp.StatusCode, cc.expectedCode)
assert.Equal(t, data, cc.expected)
assert.Equal(t, cc.expectedCode, resp.StatusCode)
assert.Equal(t, cc.expected, data)
assert.NoError(t, err)
}
})
Expand Down
2 changes: 1 addition & 1 deletion applicationset/services/pull_request/azure_devops_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func TestBuildURL(t *testing.T) {
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
result := buildURL(tc.url, tc.organization)
assert.Equal(t, result, tc.expected)
assert.Equal(t, tc.expected, result)
})
}
}
8 changes: 4 additions & 4 deletions applicationset/services/pull_request/gitea_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,10 @@ func TestGiteaList(t *testing.T) {
prs, err := host.List(context.Background())
assert.NoError(t, err)
assert.Len(t, prs, 1)
assert.Equal(t, prs[0].Number, 1)
assert.Equal(t, prs[0].Branch, "test")
assert.Equal(t, prs[0].TargetBranch, "main")
assert.Equal(t, prs[0].HeadSHA, "7bbaf62d92ddfafd9cc8b340c619abaec32bc09f")
assert.Equal(t, 1, prs[0].Number)
assert.Equal(t, "test", prs[0].Branch)
assert.Equal(t, "main", prs[0].TargetBranch)
assert.Equal(t, "7bbaf62d92ddfafd9cc8b340c619abaec32bc09f", prs[0].HeadSHA)
}

func TestGetGiteaPRLabelNames(t *testing.T) {
Expand Down
8 changes: 4 additions & 4 deletions applicationset/services/pull_request/gitlab_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ func TestList(t *testing.T) {
prs, err := svc.List(context.Background())
assert.NoError(t, err)
assert.Len(t, prs, 1)
assert.Equal(t, prs[0].Number, 15442)
assert.Equal(t, prs[0].Branch, "use-structured-logging-for-db-load-balancer")
assert.Equal(t, prs[0].TargetBranch, "master")
assert.Equal(t, prs[0].HeadSHA, "2fc4e8b972ff3208ec63b6143e34ad67ff343ad7")
assert.Equal(t, 15442, prs[0].Number)
assert.Equal(t, "use-structured-logging-for-db-load-balancer", prs[0].Branch)
assert.Equal(t, "master", prs[0].TargetBranch)
assert.Equal(t, "2fc4e8b972ff3208ec63b6143e34ad67ff343ad7", prs[0].HeadSHA)
}

func TestListWithLabels(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion applicationset/services/scm_provider/github_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ func TestGithubGetBranches(t *testing.T) {
if err != nil {
assert.NoError(t, err)
} else {
assert.Equal(t, repos[0].Branch, "master")
assert.Equal(t, "master", repos[0].Branch)
}
//Branch Doesn't exists instead of error will return no error
repo2 := &Repository{
Expand Down
2 changes: 1 addition & 1 deletion applicationset/services/scm_provider/gitlab_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1213,7 +1213,7 @@ func TestGitlabGetBranches(t *testing.T) {
t.Run("branch exists", func(t *testing.T) {
repos, err := host.GetBranches(context.Background(), repo)
assert.NoError(t, err)
assert.Equal(t, repos[0].Branch, "master")
assert.Equal(t, "master", repos[0].Branch)
})

repo2 := &Repository{
Expand Down
8 changes: 4 additions & 4 deletions applicationset/utils/clusterUtils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ func Test_secretToCluster(t *testing.T) {
}
cluster, err := secretToCluster(secret)
assert.NoError(t, err)
assert.Equal(t, *cluster, argoappv1.Cluster{
assert.Equal(t, argoappv1.Cluster{
Name: "test",
Server: "http://mycluster",
Config: argoappv1.ClusterConfig{
Username: "foo",
},
})
}, *cluster)
}

// From Argo CD util/db/cluster_test.go
Expand All @@ -57,10 +57,10 @@ func Test_secretToCluster_NoConfig(t *testing.T) {
}
cluster, err := secretToCluster(secret)
assert.NoError(t, err)
assert.Equal(t, *cluster, argoappv1.Cluster{
assert.Equal(t, argoappv1.Cluster{
Name: "test",
Server: "http://mycluster",
})
}, *cluster)
}

func createClusterSecret(secretName string, clusterName string, clusterServer string) *corev1.Secret {
Expand Down
32 changes: 16 additions & 16 deletions applicationset/utils/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,12 @@ func TestRenderTemplateParams(t *testing.T) {
// the target field has been templated into the expected value
actualValue := *getPtrFunc(newApplication)
assert.Equal(t, test.expectedVal, actualValue, "Field '%s' had an unexpected value. expected: '%s' value: '%s'", fieldName, test.expectedVal, actualValue)
assert.Equal(t, newApplication.ObjectMeta.Annotations["annotation-key"], "annotation-value")
assert.Equal(t, newApplication.ObjectMeta.Annotations["annotation-key2"], "annotation-value2")
assert.Equal(t, newApplication.ObjectMeta.Labels["label-key"], "label-value")
assert.Equal(t, newApplication.ObjectMeta.Labels["label-key2"], "label-value2")
assert.Equal(t, newApplication.ObjectMeta.Name, "application-one")
assert.Equal(t, newApplication.ObjectMeta.Namespace, "default")
assert.Equal(t, "annotation-value", newApplication.ObjectMeta.Annotations["annotation-key"])
assert.Equal(t, "annotation-value2", newApplication.ObjectMeta.Annotations["annotation-key2"])
assert.Equal(t, "label-value", newApplication.ObjectMeta.Labels["label-key"])
assert.Equal(t, "label-value2", newApplication.ObjectMeta.Labels["label-key2"])
assert.Equal(t, "application-one", newApplication.ObjectMeta.Name)
assert.Equal(t, "default", newApplication.ObjectMeta.Namespace)
assert.Equal(t, newApplication.ObjectMeta.UID, types.UID("d546da12-06b7-4f9a-8ea2-3adb16a20e2b"))
assert.Equal(t, newApplication.ObjectMeta.CreationTimestamp, application.ObjectMeta.CreationTimestamp)
assert.NoError(t, err)
Expand Down Expand Up @@ -250,7 +250,7 @@ func TestRenderHelmValuesObjectJson(t *testing.T) {
err = json.Unmarshal(newApplication.Spec.Source.Helm.ValuesObject.Raw, &unmarshaled)

assert.NoError(t, err)
assert.Equal(t, unmarshaled.(map[string]interface{})["some"].(map[string]interface{})["string"], "Hello world")
assert.Equal(t, "Hello world", unmarshaled.(map[string]interface{})["some"].(map[string]interface{})["string"])

}

Expand Down Expand Up @@ -302,7 +302,7 @@ func TestRenderHelmValuesObjectYaml(t *testing.T) {
err = json.Unmarshal(newApplication.Spec.Source.Helm.ValuesObject.Raw, &unmarshaled)

assert.NoError(t, err)
assert.Equal(t, unmarshaled.(map[string]interface{})["some"].(map[string]interface{})["string"], "Hello world")
assert.Equal(t, "Hello world", unmarshaled.(map[string]interface{})["some"].(map[string]interface{})["string"])

}

Expand Down Expand Up @@ -640,12 +640,12 @@ func TestRenderTemplateParamsGoTemplate(t *testing.T) {
assert.NoError(t, err)
actualValue := *getPtrFunc(newApplication)
assert.Equal(t, test.expectedVal, actualValue, "Field '%s' had an unexpected value. expected: '%s' value: '%s'", fieldName, test.expectedVal, actualValue)
assert.Equal(t, newApplication.ObjectMeta.Annotations["annotation-key"], "annotation-value")
assert.Equal(t, newApplication.ObjectMeta.Annotations["annotation-key2"], "annotation-value2")
assert.Equal(t, newApplication.ObjectMeta.Labels["label-key"], "label-value")
assert.Equal(t, newApplication.ObjectMeta.Labels["label-key2"], "label-value2")
assert.Equal(t, newApplication.ObjectMeta.Name, "application-one")
assert.Equal(t, newApplication.ObjectMeta.Namespace, "default")
assert.Equal(t, "annotation-value", newApplication.ObjectMeta.Annotations["annotation-key"])
assert.Equal(t, "annotation-value2", newApplication.ObjectMeta.Annotations["annotation-key2"])
assert.Equal(t, "label-value", newApplication.ObjectMeta.Labels["label-key"])
assert.Equal(t, "label-value2", newApplication.ObjectMeta.Labels["label-key2"])
assert.Equal(t, "application-one", newApplication.ObjectMeta.Name)
assert.Equal(t, "default", newApplication.ObjectMeta.Namespace)
assert.Equal(t, newApplication.ObjectMeta.UID, types.UID("d546da12-06b7-4f9a-8ea2-3adb16a20e2b"))
assert.Equal(t, newApplication.ObjectMeta.CreationTimestamp, application.ObjectMeta.CreationTimestamp)
}
Expand Down Expand Up @@ -701,7 +701,7 @@ func TestRenderTemplateKeys(t *testing.T) {
newApplication, err := render.RenderTemplateParams(application, nil, params, false, nil)
require.NoError(t, err)
require.Contains(t, newApplication.ObjectMeta.Annotations, "annotation-some-key")
assert.Equal(t, newApplication.ObjectMeta.Annotations["annotation-some-key"], "annotation-some-value")
assert.Equal(t, "annotation-some-value", newApplication.ObjectMeta.Annotations["annotation-some-key"])
})
t.Run("gotemplate", func(t *testing.T) {
application := &argoappsv1.Application{
Expand All @@ -721,7 +721,7 @@ func TestRenderTemplateKeys(t *testing.T) {
newApplication, err := render.RenderTemplateParams(application, nil, params, true, nil)
require.NoError(t, err)
require.Contains(t, newApplication.ObjectMeta.Annotations, "annotation-some-key")
assert.Equal(t, newApplication.ObjectMeta.Annotations["annotation-some-key"], "annotation-some-value")
assert.Equal(t, "annotation-some-value", newApplication.ObjectMeta.Annotations["annotation-some-key"])
})
}

Expand Down
2 changes: 1 addition & 1 deletion applicationset/webhook/webhook_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func TestWebhookHandler(t *testing.T) {
w := httptest.NewRecorder()

h.Handler(w, req)
assert.Equal(t, w.Code, test.expectedStatusCode)
assert.Equal(t, test.expectedStatusCode, w.Code)

list := &v1alpha1.ApplicationSetList{}
err = fc.List(context.TODO(), list)
Expand Down
4 changes: 2 additions & 2 deletions cmd/argocd/commands/admin/app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ func TestGetReconcileResults_Refresh(t *testing.T) {
return
}

assert.Equal(t, result[0].Health.Status, health.HealthStatusMissing)
assert.Equal(t, result[0].Sync.Status, v1alpha1.SyncStatusCodeOutOfSync)
assert.Equal(t, health.HealthStatusMissing, result[0].Health.Status)
assert.Equal(t, v1alpha1.SyncStatusCodeOutOfSync, result[0].Sync.Status)
}

func TestDiffReconcileResults_NoDifferences(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions cmd/argocd/commands/admin/project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestUpdateProjects_FindMatchingProject(t *testing.T) {

barProj, err := clientset.ArgoprojV1alpha1().AppProjects(namespace).Get(ctx, "bar", v1.GetOptions{})
assert.NoError(t, err)
assert.EqualValues(t, barProj.Spec.Roles[0].Policies, []string{"p, proj:bar:test, *, set, bar/*, allow"})
assert.EqualValues(t, []string{"p, proj:bar:test, *, set, bar/*, allow"}, barProj.Spec.Roles[0].Policies)
}

func TestUpdateProjects_FindMatchingRole(t *testing.T) {
Expand All @@ -59,7 +59,7 @@ func TestUpdateProjects_FindMatchingRole(t *testing.T) {

proj, err := clientset.ArgoprojV1alpha1().AppProjects(namespace).Get(ctx, "proj", v1.GetOptions{})
assert.NoError(t, err)
assert.EqualValues(t, proj.Spec.Roles[0].Policies, []string{"p, proj:proj:foo, *, set, proj/*, allow"})
assert.EqualValues(t, []string{"p, proj:proj:foo, *, set, proj/*, allow"}, proj.Spec.Roles[0].Policies)
assert.Empty(t, proj.Spec.Roles[1].Policies)
}

Expand Down
20 changes: 10 additions & 10 deletions cmd/argocd/commands/app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1428,39 +1428,39 @@ func TestParseSelectedResources(t *testing.T) {
operationResources, err := parseSelectedResources(resources)
assert.NoError(t, err)
assert.Len(t, operationResources, 5)
assert.Equal(t, *operationResources[0], v1alpha1.SyncOperationResource{
assert.Equal(t, v1alpha1.SyncOperationResource{
Namespace: "",
Name: "test",
Kind: application.ApplicationKind,
Group: "v1alpha",
})
assert.Equal(t, *operationResources[1], v1alpha1.SyncOperationResource{
}, *operationResources[0])
assert.Equal(t, v1alpha1.SyncOperationResource{
Namespace: "namespace",
Name: "test",
Kind: application.ApplicationKind,
Group: "v1alpha",
})
assert.Equal(t, *operationResources[2], v1alpha1.SyncOperationResource{
}, *operationResources[1])
assert.Equal(t, v1alpha1.SyncOperationResource{
Namespace: "",
Name: "test",
Kind: "Application",
Group: "v1alpha",
Exclude: true,
})
assert.Equal(t, *operationResources[3], v1alpha1.SyncOperationResource{
}, *operationResources[2])
assert.Equal(t, v1alpha1.SyncOperationResource{
Namespace: "default",
Name: "test",
Kind: "Deployment",
Group: "apps",
Exclude: false,
})
assert.Equal(t, *operationResources[4], v1alpha1.SyncOperationResource{
}, *operationResources[3])
assert.Equal(t, v1alpha1.SyncOperationResource{
Namespace: "",
Name: "*",
Kind: "*",
Group: "*",
Exclude: true,
})
}, *operationResources[4])
}

func TestParseSelectedResourcesIncorrect(t *testing.T) {
Expand Down
16 changes: 8 additions & 8 deletions cmd/argocd/commands/cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ import (

func Test_getQueryBySelector(t *testing.T) {
query := getQueryBySelector("my-cluster")
assert.Equal(t, query.Name, "my-cluster")
assert.Equal(t, query.Server, "")
assert.Equal(t, "my-cluster", query.Name)
assert.Equal(t, "", query.Server)

query = getQueryBySelector("http://my-server")
assert.Equal(t, query.Name, "")
assert.Equal(t, query.Server, "http://my-server")
assert.Equal(t, "", query.Name)
assert.Equal(t, "http://my-server", query.Server)

query = getQueryBySelector("https://my-server")
assert.Equal(t, query.Name, "")
assert.Equal(t, query.Server, "https://my-server")
assert.Equal(t, "", query.Name)
assert.Equal(t, "https://my-server", query.Server)
}

func Test_printClusterTable(t *testing.T) {
Expand Down Expand Up @@ -98,9 +98,9 @@ func Test_getRestConfig(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got, err := getRestConfig(tt.args.pathOpts, tt.args.ctxName); err == nil {
require.Equal(t, got, tt.expected)
require.Equal(t, tt.expected, got)
} else if tt.wantErr {
require.Equal(t, err.Error(), tt.expectedErr)
require.Equal(t, tt.expectedErr, err.Error())
} else {
t.Errorf("An unexpected error occurred during test %s:\n%s", tt.name, err.Error())
}
Expand Down
Loading