Skip to content

Commit

Permalink
Cr 12173 fix child apps deletion (#128)
Browse files Browse the repository at this point in the history
* Fixed deletion of child apps

* bump version

Co-authored-by: danielm-codefresh <[email protected]>
  • Loading branch information
roi-codefresh and danielm-codefresh authored Jul 27, 2022
1 parent c66810b commit ef441d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.3.4-cap-CR-13327-bump-ubuntu-version
2.3.4-cap-CR-12173-fix-child-apps-deletion
2 changes: 1 addition & 1 deletion server/application/application_event_reporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func (s *applicationEventReporter) streamApplicationEvents(
logCtx.WithError(err).Error("failed to get application tree")
}

if isChildApp(a) {
if isChildApp(a) && a.DeletionTimestamp == nil {
parentApp := a.Labels[common.LabelKeyAppInstance]

parentApplicationEntity, err := s.server.Get(ctx, &application.ApplicationQuery{
Expand Down

0 comments on commit ef441d9

Please sign in to comment.