fix helm application (#149)

codefresh-io · Sep 19, 2022 · ec314b3 · ec314b3
1 parent 64c034e
commit ec314b3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-2.3.4-cap-CR-14605-default-operation-revision
+2.3.4-cap-CR-fix-helm-application
diff --git a/server/application/application_event_reporter.go b/server/application/application_event_reporter.go
@@ -132,13 +132,11 @@ func (s *applicationEventReporter) streamApplicationEvents(
 
 		desiredManifests, _, manifestGenErr := s.getDesiredManifests(ctx, parentApplicationEntity, logCtx)
 
-		revisionMetadata, err := s.getApplicationRevisionDetails(ctx, a, getOperationRevision(a))
+		// helm app hasnt revision
+		// TODO: add check if it helm application
+		revisionMetadata, _ := s.getApplicationRevisionDetails(ctx, a, getOperationRevision(a))
 
-		if err == nil {
-			s.processResource(ctx, *rs, parentApplicationEntity, logCtx, ts, desiredManifests, stream, appTree, es, manifestGenErr, a, revisionMetadata, true)
-		} else {
-			return fmt.Errorf("failed to get operation revision metadata event for resource %s/%s: %w", a.Namespace, a.Name, err)
-		}
+		s.processResource(ctx, *rs, parentApplicationEntity, logCtx, ts, desiredManifests, stream, appTree, es, manifestGenErr, a, revisionMetadata, true)
 	} else {
 		// application events for child apps would be sent by its parent app
 		// as resource event
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		2.3.4-cap-CR-14605-default-operation-revision
		2.3.4-cap-CR-fix-helm-application