Skip to content

Commit

Permalink
chore: update version to 2.8-2024.02.13-b35217503
Browse files Browse the repository at this point in the history
  • Loading branch information
pasha-codefresh committed Feb 13, 2024
1 parent b352175 commit 11b040b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.8-2024.02.13-ee378953a
2.8-2024.02.13-b35217503
3 changes: 2 additions & 1 deletion server/application/application.go
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ func (s *Server) Delete(ctx context.Context, q *application.ApplicationDeleteReq
}

log.Infof("Deleting application '%s' from namespace '%s', cascade deletion is %t", appName, appNs, q.Cascade != nil)

err = s.appclientset.ArgoprojV1alpha1().Applications(appNs).Delete(ctx, appName, metav1.DeleteOptions{})
if err != nil {
return nil, fmt.Errorf("error deleting application: %w", err)
Expand Down Expand Up @@ -1556,6 +1556,7 @@ func (s *Server) DeleteResource(ctx context.Context, q *application.ApplicationR
deleteOption = metav1.DeleteOptions{PropagationPolicy: &propagationPolicy}
}
err = s.kubectl.DeleteResource(ctx, config, res.GroupKindVersion(), res.Name, res.Namespace, deleteOption)
log.Infof("Deleting resource '%s' from namespace '%s', cascade deletion is %t", res.Name, res.Namespace, !q.GetOrphan())
if err != nil {
return nil, fmt.Errorf("error deleting resource: %w", err)
}
Expand Down

0 comments on commit 11b040b

Please sign in to comment.