Feature/rpgle_2023_oct

[worksofliam]

Changes

• Token support for WHEN-IS and WHEN-IN
• Token support for enum structures groups.
• Enum structure groups appear in content assist and outline view

Checklist

• have tested my change
• updated relevant documentation
• Remove any/all console.logs I added
• eslint is not complaining
• have added myself to the contributors' list in the README
• for feature PRs: PR only includes one feature enhancement.

[chrjorgensen]

@worksofliam Looking good, the ENUMs and constants are recognized and shown in Outline and Content Assist. 👍

I have only a few issues:

• How do I test the WHEN tokens being recognized?
• I would expect the subitems in a qualified ENUM to be shown in Content Assist, when I type the name of the ENUM and a dot and Ctrl-Space - but they are not in the list? This is also a problem for subfields in a data structure, so maybe it is an old problem? If I don't qualify the ENUM or data structure, the subitems appear in the Content Assist list...

[worksofliam]

@chrjorgensen

How do I test the WHEN tokens being recognized?

The way we can test for this is by using WHEN, WHEN-IN or WHEN-IS with the indent lint rule enabled.

when I type the name of the ENUM and a dot and Ctrl-Space - but they are not in the list?

That is odd. See this screenshot below that shows the content assist after I use the dot/period trigger.

[worksofliam]

@chrjorgensen I added two tests cases for the new WHEN operators. Thanks for getting on my case to do that!

[chrjorgensen]

@worksofliam I did a fresh install of VS Code, Code for IBM i and RPGLE extension in a new Windows profile.
But I get this when opening a slightly modified sample of your code and pressing Ctrl-Enter after the dot:

I don't know what going on here... not like your experience at all...???

[worksofliam]

@chrjorgensen okay I see what's going on.

Control+space will only show in scope references. You will only see subfields when you press dot after the structure.

[chrjorgensen]

@worksofliam Finally found the setting, that prohibited the pop-up when entering the dot after the structure:

"editor.suggestOnTriggerCharacters": false,

After removal of this setting, the subfields are shown after entering the dot character.

Will review your code tomorrow.

[worksofliam]

Totally cool! Weird that it was off though.

[chrjorgensen]

Totally cool! Weird that it was off though.

Probably me that have turned if off at some point - annoyed by the pop-ups... 😆

[chrjorgensen]

@worksofliam Looking good - only a few issues...

[chrjorgensen]

@worksofliam Some final issues - when fixed we can approve and merge! 🚀

[worksofliam]

@chrjorgensen Issues resolved. Over to you for approval, and if you want to.. merge 😄

[chrjorgensen]

@worksofliam Great - let's approve and merge! 🚀

[chrjorgensen]

@worksofliam I don't have write access and can't merge... 😭