Add shortcut to search object and IFS browsers #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebjulliand
reviewed
May 10, 2024
sebjulliand
reviewed
May 10, 2024
sebjulliand
requested changes
May 10, 2024
There was a problem hiding this comment.
Small but nice change. 👌🏻
I'd just ask for a small change. Since this doesn't actually search but highlights existing entries in the Treeviews, I'd suggest a change of icon and label for these actions.
Thank you @julesyan and welcome to the contributors! 🥳
Co-authored-by: Sébastien Julliand <[email protected]>
Co-authored-by: Sébastien Julliand <[email protected]>
sebjulliand
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a shortcut to the Object Browser and IFS Browser to search the lists
Completes #2028
How to test this PR
Checklist
console.logs I added