Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show SELF logs that since the selected job has started #268

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

worksofliam
Copy link
Contributor

This fixes a seriously SELF performance issue by only showing logs for the user since the selected job has started.

Copy link

👋 A new build is available for this PR based on ce4d951.

@worksofliam worksofliam requested a review from ajshedivy August 26, 2024 17:11
@worksofliam worksofliam linked an issue Aug 26, 2024 that may be closed by this pull request
@@ -111,7 +111,8 @@ export class selfCodesResultsView implements TreeDataProvider<any> {
job_name, user_name, reason_code, logged_time, logged_sqlstate, logged_sqlcode, matches, stmttext, message_text, message_second_level_text,
program_library, program_name, program_type, module_name, client_applname, client_programid, initial_stack
FROM qsys2.sql_error_log, lateral (select * from TABLE(SYSTOOLS.SQLCODE_INFO(logged_sqlcode)))
where user_name = current_user ${onlySelected ? `and job_name = '${selected.job.id}'` : ``}
where user_name = current_user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@worksofliam worksofliam merged commit 4cfa462 into main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear out very old SELF logs when using auto refresh mode
2 participants