Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of code that checks OS version and features #223

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Cleanup of code that checks OS version and features #223

merged 3 commits into from
Apr 2, 2024

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Apr 1, 2024 •
edited
Loading

  • Cleans up the logic that determines the OS version, Db2 level and what features are enabled by moving all the logic into an IBM i class, which we can use to tie this kind of information to.
  • Fixes a bug where when connecting to a system, but the user doesn't have correct authority to group_ptf_info, then it would
    • a) not finish the startup process correctly,
    • b) completely disabled SELF, and
    • c) failed to start a job up automatically based on the configured option
  • Fixes invalid hoover tooltip on SELF stack

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

👋 A new build is available for this PR based on 517a27d.

@worksofliam
Copy link
Contributor Author

This may fix #222

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

👋 A new build is available for this PR based on 85f3e5e.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

👋 A new build is available for this PR based on 19c94f7.

forstie
forstie approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 7.4, looks great

@worksofliam worksofliam merged commit 7be8c01 into main Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forstie forstie forstie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worksofliam @forstie