Examples browser cleanup #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
Signed-off-by: Seb Julliand <[email protected]>
worksofliam
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Cool - this logic is much easier to follow. Thanks @sebjulliand!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Examples browser looped when loading if no SQL job was started, because loading the Services called
refreshwhich in turn calledgetChildren...and if the Services are still undefined (because no SQL job), then it loops.So this PR fixes that. Loading the Services example doesn't call
refreshanymore (it wasn't needed in the first place), and an information item is displayed under the Service folder to ask for an SQL job.A
Reloadwas added to the browser to allow to reload the Services example if needed.The Examples are now sorted alphabetically and their icon is the SQL file's.