Feature/self codes p2 #168
Conversation
|
👋 A new build is available for this PR based on e37f4ef. |
…to feature/self_codes_p2
|
👋 A new build is available for this PR based on d402a8e. |
…ch/vscode-db2i into feature/self_codes_p2
|
👋 A new build is available for this PR based on 8140afb. |
|
👋 A new build is available for this PR based on 0ba27a8. |
|
👋 A new build is available for this PR based on 0423ec2. |
src/views/selfCodesPanel/index.ts
Outdated
| @@ -0,0 +1,12 @@ | |||
| import * as vscode from 'vscode'; | |||
|
|
|||
| class SelfCodesPanelProvider { | |||
There was a problem hiding this comment.
Is this used anywhere? There is no export in this file.
There was a problem hiding this comment.
just used later in vscode-db2i.runEditorStatement
src/views/results/index.ts
Outdated
| import { SQLJob } from "../../connection/sqlJob"; | ||
| import LRUCache from "lru-cache"; |
There was a problem hiding this comment.
A few unused imports here. These should be removed.
|
👋 A new build is available for this PR based on 031d49b. |
|
👋 A new build is available for this PR based on a345aae. |
src/views/results/index.ts
Outdated
| } | ||
| } | ||
|
|
||
| class SelfCodePanelProvider { |
There was a problem hiding this comment.
This should be in a seperate file.
…ch/vscode-db2i into feature/self_codes_p2
|
👋 A new build is available for this PR based on 6682b89. |
|
👋 A new build is available for this PR based on cf5d7db. |
src/views/results/index.ts
Outdated
| let updateView: boolean = false; | ||
| let data = []; | ||
| for (let count = 0; count < 5; count++) { | ||
| const curData = await JobManager.runSQL(content, undefined); |
There was a problem hiding this comment.
Instead of using the JobManager here, you should just use the attached job parameter (job.query)
src/views/results/index.ts
Outdated
| break; | ||
| } | ||
| data = curData; | ||
| delay(1000); |
There was a problem hiding this comment.
This needs an await otherwise there's not wait!
|
👋 A new build is available for this PR based on f331d73. |
|
👋 A new build is available for this PR based on 705f0e4. |
|
👋 A new build is available for this PR based on 1be4d06. |
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
|
👋 A new build is available for this PR based on dae4583. |
Part 2
vscode-db2i/src/views/results/html.ts
Line 151 in 7c3126c