Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Release Notes - Added to Home Page under What's New #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Wright4i
Copy link
Contributor

Link to demo site: https://wright4i.github.io/docs/

Uses GitHub API to grab details of a public repo (vscode-ibmi)

Home Page

image

  • Dynamic latest version number
  • Only link to Release Notes. I felt like it didn't need to be a sidebar item - thoughts?

Release Notes

image

  • Dynamically pulls latest 5 releases. githubAPI.ts's fetchFromGithub() has a default limit: number = 5 so we can adjust to taste.
  • Button at bottom linking to release page for vscode-ibmi

Packages added to project

Server side only, no performance impact

dotenv

Reason - Best practices. Needed .env files for API_GITHUB_TOKEN. Created .env.example for local development.

marked

Reason - Release notes from API was in markdown. marked converted to HTML so I could set the innerHTML of the astro component.

Tasks to Build on Merge

  • Needs a new GitHub API token with public_repo scope
  • Token should be added to Repository secrets as API_GITHUB_TOKEN
  • .github/workflows/astro.yml was updated to import API_GITHUB_TOKEN
  • (optional, recommended) update build workflow in vscode-ibmi to trigger build on docs so Release Notes are always current

@Wright4i Wright4i added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 29, 2024
@Wright4i Wright4i requested a review from worksofliam February 29, 2024 16:45
@worksofliam
Copy link
Contributor

@Wright4i Interesting. Why is the token required? Can you not access the public API for released without a token?

@Wright4i
Copy link
Contributor Author

Wright4i commented Feb 29, 2024

@Wright4i Interesting. Why is the token required? Can you not access the public API for released without a token?

@worksofliam You'd think, but I tried and it didn't work. Guessing so they can track you for rate-limiting/abuse purposes.

@chrjorgensen
Copy link
Contributor

@Wright4i @worksofliam Shouldn't we try and complete this? Would be great to have in the docs... 😍

@Wright4i
Copy link
Contributor Author

@chrjorgensen you're right! I completely forgot this was out here open.

@worksofliam any issues with the API key usage? If not I can address the conflicts and we can get this merged in.

@worksofliam
Copy link
Contributor

@Wright4i No problem with token usage! This would be cool to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants