Fix SA Warning (#359)

* Fixes a warning about
`Attorney.legal_case_plaintiff` and
`Attorney.legal_case_defendant` being created improperly.

* Convert relationships to strings in the
legal_case model.

* Set User email column to `cache_ok` = true

* This time, with feeling...

backend/database/models/attorney.py

@@ -3,5 +3,4 @@
 
 class Attorney(db.Model):
     id = db.Column(db.Integer, primary_key=True)
-    legal_case_id = db.Column(db.Integer, db.ForeignKey("legal_case.id"))
     text_contents = db.Column(db.String)

backend/database/models/legal_case.py

@@ -3,7 +3,6 @@
 
 
 class LegalCaseType(str, enum.Enum):
-    # TODO: Do we want string enumerations to be all caps? i.e. CIVIL = "CIVIL"
     CIVIL = "CIVIL"
     CRIMINAL = "CRIMINAL"
 
@@ -15,15 +14,10 @@ class LegalCase(db.Model):
     jurisdiction = db.Column(db.String)
     judge = db.Column(db.String)
     docket_number = db.Column(db.String)
-    # TODO: Foreign key to officer/victim?
     defendant = db.Column(db.String)
-    defendant_council = db.relationship(
-        "Attorney", backref="legal_case_defendant", uselist=False
-    )
+    defendant_council = db.Column(db.String)
     plaintiff = db.Column(db.String)
-    plaintiff_council = db.relationship(
-        "Attorney", backref="legal_case_plaintiff", uselist=False
-    )
+    plaintiff_council = db.Column(db.String)
     start_date = db.Column(db.DateTime)
     end_date = db.Column(db.DateTime)
     outcome = db.Column(db.String)

backend/database/models/user.py

@@ -20,6 +20,7 @@ class CI_String(TypeDecorator):
     """Case-insensitive String subclass definition"""
 
     impl = String
+    cache_ok = True
 
     def __init__(self, length, **kwargs):
         if kwargs.get("collate"):
@@ -69,7 +70,8 @@ class User(db.Model, UserMixin, CrudMixin):
     # User authentication information. The collation="NOCASE" is required
     # to search case insensitively when USER_IFIND_MODE is "nocase_collation".
     email = db.Column(
-        CI_String(255, collate="NOCASE"), nullable=False, unique=True
+        CI_String(255, collate="NOCASE"),
+        nullable=False, unique=True
     )
     email_confirmed_at = db.Column(db.DateTime())
     password = db.Column(db.String(255), nullable=False, server_default="")