Hide the Follow button for logged-out users #1669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rashid-123
requested review from
sashamaryl,
mertbagt,
nesanders,
mvictor55,
timblais,
alexjball,
Mephistic and
kiminkim724
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Mephistic
requested changes
Jan 9, 2025
| @@ -34,7 +34,8 @@ const StyledImage = styled(Image)` | |||
| export const BillDetails = ({ bill }: BillProps) => { | |||
| const { t } = useTranslation("common") | |||
|
|
|||
| const isPendingUpgrade = useAuth().claims?.role === "pendingUpgrade" | |||
| const { user } = useAuth() // Get the logged-in user (adjust according to your auth logic) | |||
There was a problem hiding this comment.
This doesn't work because user isn't the root of the state returned by useAuth() (see https://github.com/codeforboston/maple/blob/main/components/auth/redux.ts#L17 for the structure of the auth state). The auth state has both user and claims as top-level keys, so trying to get claims from user instead in the isPendingUpdate check breaks the build.
This could be adjusted to work correctly by destructuring both user and claims from useAuth() (e.g. const { user, claims } = useAuth()
| @@ -34,7 +34,8 @@ const StyledImage = styled(Image)` | |||
| export const BillDetails = ({ bill }: BillProps) => { | |||
| const { t } = useTranslation("common") | |||
|
|
|||
| const isPendingUpgrade = useAuth().claims?.role === "pendingUpgrade" | |||
| const { user } = useAuth() // Get the logged-in user (adjust according to your auth logic) | |||
| const isPendingUpgrade = user?.claims?.role === "pendingUpgrade" // Ensure the role check is based on the authenticated user | |||
There was a problem hiding this comment.
Also, I feel like the comments here are unnecessary - your code seems pretty self-explanatory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "Follow" button is now correctly hidden for logged-out users.
Steps to test/reproduce
1 . Test with Logged-out User:
- Open the bill detail page (e.g., https://maple-dev.vercel.app/bills/193/H3259).
-Ensure you are logged out.
-Verify that the "Follow" button is not visible on the page.
2 . Test with Logged-in User:
-Log in as an authenticated user.
-Navigate to the same bill detail page.
-Verify that the "Follow" button is visible and can be interacted with.