Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow btn individual users #1654

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Follow btn individual users #1654

merged 5 commits into from
Dec 18, 2024

Conversation

aaerhart
Copy link
Collaborator

@aaerhart aaerhart commented Dec 4, 2024 •
edited
Loading

Summary

Adds the follow button and request to individual users both on their profile and on each search result card. #1592

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Screenshot 2024-12-03 at 8 31 33 PM Screenshot 2024-12-03 at 8 31 01 PM Screenshot 2024-12-03 at 8 30 43 PM

Steps to test/reproduce

  1. Go to a user's profile page
  2. Notice the Follow button
  3. Click on the button
  4. Go to Browse Testimony page, notice Follow button on cards that are ind. users
  5. Click on the button
  6. Your own profile should not have this button

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 1:45am

Mephistic
Mephistic approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/search/testimony/TestimonyHit.tsx Show resolved Hide resolved
@aaerhart aaerhart closed this Dec 18, 2024
@aaerhart aaerhart reopened this Dec 18, 2024
@Mephistic Mephistic merged commit fafe412 into codeforboston:main Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiminkim724 kiminkim724 kiminkim724 left review comments

@Mephistic Mephistic Mephistic approved these changes

@sashamaryl sashamaryl Awaiting requested review from sashamaryl sashamaryl is a code owner

@mertbagt mertbagt Awaiting requested review from mertbagt mertbagt is a code owner

@nesanders nesanders Awaiting requested review from nesanders nesanders is a code owner

@mvictor55 mvictor55 Awaiting requested review from mvictor55 mvictor55 is a code owner

@timblais timblais Awaiting requested review from timblais timblais is a code owner

@alexjball alexjball Awaiting requested review from alexjball alexjball is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaerhart @Mephistic @kiminkim724 @mertbagt