Tests: Lewitus, Quateman, Shen, Vitti, Yellepeddi #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the pytest fixture params
jkwan2011
reviewed
Oct 26, 2023
AdamFinkle
pushed a commit
to AdamFinkle/home-energy-analysis-tool
that referenced
this pull request
May 22, 2024
* rules engine tests: Lewitus and Quateman Also fix the pytest fixture params * rules engine tests: Shen, Vitti, Yellepeddi * satisfy mypy * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More examples for the rules engine tests.
I had to change the balance point sensitivity to 0.5 for a few of them.
The "Shen" test case was made before the bug fix in July, so I redid the analysis with a newer version of the spreadsheet.
Also I changed the little annotation so that the tests actually run