This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Search and sort bar repositioning (341+342) #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(sort does not work)
This reverts commit b96496d.
…n/communityconnect into development" This reverts commit f5ae0c2.
This reverts commit 465aa6e.
|
Hey Brandon! There is still some functionality problems with this change. Specifically, upon checking categories or writing in the search box, no resources are filtered. |
|
Closing due to big changes via css refactor #372 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current design on Marvel has the search bar centered and the sort bar to the left. These have been moved to match the design. Much of the code in AdminPage.js, CardGrid.js, and CategoryList.js was rearranged to allow the sorting by distance functionality to still work.
NOTE: There is one small thing with the UI. The sort bar is a little bit squished against the category section on laptops and the header on mobile. I'm aware that the CSS is being changed/refactored right now, but I'm not sure in what way. Someone else should add some margin to the sort bar.
Fixes #
This is for issues #341 and #342.
Motivation and Context
This is a UI enhancement and is the first steps to making the admin page look like the mock-up design on Marvel (https://marvelapp.com/c054d54/screen/57793613).
Type of change