Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates de.js #996

Merged

Conversation

ValerieKenyon
Copy link
Collaborator

Brings de.js up-to-date with en.js. It's been a while since I've done one of these, I hope I did it okay.

Copy link
Collaborator

@knod knod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know German! It looks great!

@knod
Copy link
Collaborator

knod commented Nov 14, 2018

None of this needs to block the merge. This is all fine. Unless I've missed typos, in which case it's my bad.

From #997, @ValerieKenyon says:

(BTW: I was working from en.js in the google docs, updating to de.js in the google docs, and then creating a new, up-to-date branch. I copied and pasted my German from the google doc into the new branch and tweaked it in VS Code. I also noticed that the en.js in dev branch (and in germanTranslation18_11_13) has a lot more text in it than the en.js google doc, so my updated de.js doesn't actually contain this newer text.)

I can't tell exactly what you mean, but it sounds like the google doc is out of date, so someone needs to go through and update it carefully. There are about to be more changes to it, so after the next couple merges, which should happen in just a few minutes, anyone can feel free to take that on. There's actually an issue for that already.

For English, we can basically just cut and paste the local changes into the google doc. The updates to the other languages need to happen more carefully.

@ValerieKenyon : Is that something you'd be interested in doing/have time to do?

@ValerieKenyon ValerieKenyon merged commit ccd70e9 into codeforboston:dev Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants