Fill more of test_brookline_controller #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I filled in a bit more of the Brookline Controller test to help address #20 with much of what I can try to cover the brookline_controller.py. My concern right now is that is the current set of tests is sufficient enough? And this is where I hope I can try to resolve with incorporating code coverage with trying to get codecov in Travis CI working.
The thing in particular that I am concerned about is
on_session_startedandon_session_endednot being called at all and I am unsure if that is something that should be included in the test.Other than that, let me know if there are other things I should address for the controller test in particular. One other change is moving all of the output_speech into a constant variable for the module so testing could be more easily be operable, but let me know if you approve of this change or not.