Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on application to run database migrations for docker-compose #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jszwedko
Copy link
Contributor

Curious to get thoughts on this one!

I personally view it as a responsibility of the application to run database migrations. Rather than build a separate docker image that is the mdillon/postgis + the dumped schema from rake db:migrate and friends (imported in the entrypoint), we can instead use the image as-is and rely on docker-compose to run the migrations as part of docker-compose up.

Overall I think this reduces maintenance burden, but I'm open to other thoughts.

Depends on #284

Rather than building separate image.
@jszwedko jszwedko changed the title Rely on application to run database migrations Rely on application to run database migrations in docker Jul 16, 2018
@jszwedko jszwedko changed the title Rely on application to run database migrations in docker Rely on application to run database migrations for docker-compose Jul 16, 2018
@bigfleet
Copy link
Contributor

@jszwedko I am 💯 in favor of this getting a flavor of citygram/data image, with a specific tag. I do think these data images represent the opportunity to pull representative datasets (for example, to let some dev somewhere deal with what happens when we DO have e.g. 500k rows for a city over a time period). But your use case above is much more common and just as needed. That use case is overall in good position to use some tag-- feel free to nominate it and build support for it into any pipeline that makes sense. (There might not be anything to put into the image at that point!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants