Rely on application to run database migrations for docker-compose #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious to get thoughts on this one!
I personally view it as a responsibility of the application to run database migrations. Rather than build a separate docker image that is the
mdillon/postgis
+ the dumped schema fromrake db:migrate
and friends (imported in the entrypoint), we can instead use the image as-is and rely on docker-compose to run the migrations as part ofdocker-compose up
.Overall I think this reduces maintenance burden, but I'm open to other thoughts.
Depends on #284