fix: distribution unique alias resource ID

codedazur · Sep 12, 2024 · d9802e4 · d9802e4
1 parent 0c60119
commit d9802e4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.changeset/grumpy-hairs-run.md b/.changeset/grumpy-hairs-run.md
@@ -0,0 +1,5 @@
+---
+"@codedazur/cdk-site-distribution": patch
+---
+
+Alias records now have unique resource IDs.
diff --git a/packages/cdk-site-distribution/src/constructs/SiteDistribution.ts b/packages/cdk-site-distribution/src/constructs/SiteDistribution.ts
@@ -204,9 +204,7 @@ export class SiteDistribution extends Construct {
       [subdomain, name].filter(Boolean).join("."),
     );
 
-    for (const domain in domains) {
-      new CfnOutput(this, "URL", { value: "https://" + domain });
-    }
+    new CfnOutput(this, "URL", { value: "https://" + domains[0] });
 
     return domains;
   }
@@ -524,7 +522,7 @@ export class SiteDistribution extends Construct {
 
     return domains.map(
       (domain) =>
-        new ARecord(this, "DomainAlias", {
+        new ARecord(this, `DomainAlias-${domain}`, {
           recordName: domain,
           target: RecordTarget.fromAlias(
             new CloudFrontTarget(this.distribution),