fix(react-notifications): make children and onDismiss optional

codedazur · Feb 28, 2024 · 8c88544 · 8c88544
1 parent bc4e3ad
commit 8c88544
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/quiet-sloths-change.md b/.changeset/quiet-sloths-change.md
@@ -0,0 +1,5 @@
+---
+"@codedazur/react-notifications": patch
+---
+
+The children and onDismiss props are now optional.
diff --git a/apps/storybook/stories/react-notifications/NotificationsProvider.stories.tsx b/apps/storybook/stories/react-notifications/NotificationsProvider.stories.tsx
@@ -180,7 +180,7 @@ const Notification: FunctionComponent<NotificationProps> = ({
       <EdgeInset all="0.5rem" left="1rem">
         <Row justify="space-between" align="center" gap="1rem">
           {children}
-          <Button onClick={onDismiss}>Dismiss</Button>
+          {onDismiss && <Button onClick={onDismiss}>Dismiss</Button>}
         </Row>
       </EdgeInset>
       {timer && <NotificationProgress timer={timer} />}

diff --git a/packages/react-notifications/providers/NotificationsContext.tsx b/packages/react-notifications/providers/NotificationsContext.tsx
@@ -2,9 +2,9 @@ import { Timer } from "@codedazur/essentials";
 import { ReactNode, createContext } from "react";
 
 export interface NotificationProps {
-  readonly onDismiss: () => void;
+  readonly onDismiss?: () => void;
   readonly timer?: Timer;
-  readonly children: ReactNode;
+  readonly children?: ReactNode;
 }
 
 export type NotificationGroup = Array<{