Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Redis Replication extension tests. #54

Merged
merged 12 commits into from
Feb 10, 2024
Merged

Conversation

ryan-gang
Copy link
Contributor

Fixes :

  1. Properly handle first command sent by User. (Previous test was explicitly waiting and testing for SELECT commands, updated that to skip if SELECT is received, if not proceed with assertion.)
  2. Add case sensitive matching for commands propagated. (REDIS commands are excluded.)
  3. Update all error statements statements to be more consistent.
  4. Remove 2nd WAIT test case. (Makes the entire stage > 10s).
  5. Update logs to say "Master is running on XXXX".
  6. Create FakeRedisNode to share methods between Replica and Master. (Refactor and create shared struct).
  7. Add util method readAndAssertMessagesWithSkip, and refactor code. (re : Point 1)
    Same code was used across multiple files.
  8. Add LogPrefix for other stages with multiple replicas.
  9. Update log prefix to: [replica-N] and [client].
  10. Add updated fixtures.

@ryan-gang ryan-gang self-assigned this Feb 10, 2024
@ryan-gang ryan-gang requested a review from rohitpaulk February 10, 2024 11:32
@rohitpaulk rohitpaulk merged commit 050079e into main Feb 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants