Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move shared change check to separate workflow with correct permissions #690

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Sep 5, 2024

codecov/gha-workflows#32 will change this to use main before merging

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

github-actions bot commented Sep 5, 2024

@matt-codecov matt-codecov requested a review from a team September 5, 2024 18:45
@matt-codecov matt-codecov marked this pull request as ready for review September 5, 2024 18:45
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         433      433           
  Lines       36768    36768           
=======================================
  Hits        36059    36059           
  Misses        709      709           
Flag Coverage Δ
integration 98.07% <ø> (ø)
latest-uploader-overall 98.07% <ø> (ø)
unit 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (ø)
OutsideTasks 98.07% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (8bb6b34) to head (94611d8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         433      433           
  Lines       36768    36768           
=======================================
  Hits        36059    36059           
  Misses        709      709           
Flag Coverage Δ
integration 98.07% <ø> (ø)
latest-uploader-overall 98.07% <ø> (ø)
unit 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (ø)
OutsideTasks 98.07% <ø> (ø)

Copy link

codecov-public-qa bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (8bb6b34) to head (94611d8).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         433      433           
  Lines       36768    36768           
=======================================
  Hits        36059    36059           
  Misses        709      709           
Flag Coverage Δ
integration 98.07% <ø> (ø)
latest-uploader-overall 98.07% <ø> (ø)
unit 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.95% <ø> (ø)
OutsideTasks 98.07% <ø> (ø)

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (8bb6b34) to head (94611d8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         475      475           
  Lines       38124    38124           
=======================================
  Hits        37405    37405           
  Misses        719      719           
Flag Coverage Δ
integration 98.07% <ø> (ø)
latest-uploader-overall 98.07% <ø> (ø)
unit 98.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.05% <ø> (ø)
OutsideTasks 98.07% <ø> (ø)

This change has been scanned for critical changes. Learn more

@matt-codecov matt-codecov added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 6d955fe Sep 5, 2024
27 checks passed
@matt-codecov matt-codecov deleted the matt/fix-shared-change-check branch September 5, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants