Bundle Analysis: Add asset comparison and fetching PR files #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerrySentry
changed the title
JerrySentry
commented
Jan 16, 2025
| @@ -160,6 +161,16 @@ def parse(self, path: str) -> Tuple[int, str]: | |||
| # but first we need to find the Asset by the hashed file name | |||
| dynamic_imports_list = self._parse_dynamic_imports() | |||
| if dynamic_imports_list: | |||
There was a problem hiding this comment.
Delete the old entries in the table before inserting the new data.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 90.30% 89.90% -0.41%
==========================================
Files 434 324 -110
Lines 12973 9119 -3854
Branches 2113 1615 -498
==========================================
- Hits 11715 8198 -3517
+ Misses 1143 858 -285
+ Partials 115 63 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codecov/engineering-team#3216
codecov/engineering-team#3203
Create a way AssetComparison object to better compare assets, the old version only compares the size changes whereas this new class supports loading more comparison related info. Also adds the ability to fetch list of modules related to the assets being compared including a way to filter out files.
This supporting changed will be used by the upcoming PRs for worker to enable BA PR comments to show large file changes for changed assets.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.