Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create test_analytics app and database #474

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

joseph-sentry
Copy link
Contributor

  • creates a new test_analytics django app
  • modifies the db_settings to declare a new test analytics database
  • modifies the db router to route the models from the new django app to the new database

- creates a new test_analytics django app
- modifies the db_settings to declare a new test analytics database
- modifies the db router to route the models from the new django app
  to the new database
@joseph-sentry joseph-sentry requested review from trent-codecov and a team January 17, 2025 15:38
else:
return "timeseries"
case "test_analytics":
return "test_analytics"
Copy link
Contributor

@adrian-codecov adrian-codecov Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike timeseries, there's not read replica right

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (98a9a16) to head (9432b0d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   90.28%   89.92%   -0.37%     
==========================================
  Files         427      324     -103     
  Lines       12836     9150    -3686     
  Branches     2107     1622     -485     
==========================================
- Hits        11589     8228    -3361     
+ Misses       1137      859     -278     
+ Partials      110       63      -47     
Flag Coverage Δ
shared-docker-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention here is that this will eventually replace the Flake thats defined in reports right now?
How about all the other models related to TA?

@joseph-sentry
Copy link
Contributor Author

The intention here is that this will eventually replace the Flake thats defined in reports right now?
How about all the other models related to TA?

I don't think we'll be needing them anymore given we'll be reading from BQ. The actual win in creating a new app and database connection is that we can scale the database for TA separately from coverage and all our other products

@joseph-sentry joseph-sentry added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 6c6d5a1 Jan 20, 2025
6 checks passed
@joseph-sentry joseph-sentry deleted the joseph/test-analytics branch January 20, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants