Update mypy and run it on all the files
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `mypy` only on the changed files is the wrong thing to do, as typing changes in one file can have an effect on upstream code that imports said file. Apart from removing that file filtering, this also updates the `setup-python` GHA, and `mypy` itself.
giovanni-guidini
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
mypyonly on the changed files is the wrong thing to do, as typing changes in one file can have an effect on upstream code that imports said file.Apart from removing that file filtering, this also updates the
setup-pythonGHA, andmypyitself.TBH, I don’t think this should be a centralized workflow at all.
mypyshould really be installed as a dev dependency per-repo, and run within that repo, using the local.python-versionas well, so the python and mypy versions are defined within that repo.As both python updates and mypy updates could have an effect on the results of type checking.