Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding ignore_missing temporarily #33

Merged
merged 1 commit into from
Oct 15, 2024
Merged

adding ignore_missing temporarily #33

merged 1 commit into from
Oct 15, 2024

Conversation

jason-ford-codecov
Copy link
Contributor

No description provided.

Swatinem
Swatinem approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me
another alternative would be to ignore the failure from this step
though I’m unsure why this would have any consequences to whether auto-deploys work or not, as those should be done using the "push production" step, right?

@jason-ford-codecov jason-ford-codecov merged commit b87a009 into main Oct 15, 2024
1 check passed
@jason-ford-codecov jason-ford-codecov deleted the fix/ignore_missiong branch October 15, 2024 13:48
thomasrockhu-codecov
thomasrockhu-codecov reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasrockhu-codecov thomasrockhu-codecov thomasrockhu-codecov left review comments

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-ford-codecov @Swatinem @thomasrockhu-codecov