fix: Handle ach case #3696
Open
fix: Handle ach case #3696
+39
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 193 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
|
Bundle ReportChanges will increase total bundle size by 193 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3696 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 828 828
Lines 14875 14877 +2
Branches 4230 4224 -6
=======================================
+ Hits 14690 14692 +2
Misses 176 176
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3696 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 828 828
Lines 14875 14877 +2
Branches 4222 4224 +2
=======================================
+ Hits 14690 14692 +2
Misses 176 176
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3696 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 828 828
Lines 14875 14877 +2
Branches 4230 4224 -6
=======================================
+ Hits 14690 14692 +2
Misses 176 176
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scenario where user sets up an initial checkout session with an instant payment method (like credit card), then they go to put in a new delayed notification payment method (e.g., ACH microdeposits). Then during these 2 days of waiting, they go to upgrade their Codecov account from Team to Pro. This should NOT show the modal that says it will cancel their existing incomplete upgrade. The modal should only show if this is the initial checkout session. This PR fixes that logic.