feat: Add ACH microdeposits handling #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3693 +/- ##
==========================================
- Coverage 98.78% 98.75% -0.03%
==========================================
Files 825 828 +3
Lines 14819 14875 +56
Branches 4203 4222 +19
==========================================
+ Hits 14639 14690 +51
- Misses 171 176 +5
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3693 +/- ##
==========================================
- Coverage 98.78% 98.75% -0.03%
==========================================
Files 825 828 +3
Lines 14819 14875 +56
Branches 4203 4222 +19
==========================================
+ Hits 14639 14690 +51
- Misses 171 176 +5
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
suejung-sentry
force-pushed
the
sshin/stripe-5
branch
from
ab0bc4c to
c9f5c17
Compare
suejung-sentry
force-pushed
the
sshin/stripe-5
branch
from
9a5f94d to
0df4e54
Compare
Bundle ReportChanges will increase total bundle size by 7.75kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
Files in
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
ajay-sentry
reviewed
Jan 30, 2025
src/pages/PlanPage/PlanPage.test.tsx
Outdated
| const wrapper = | ||
| (initialEntries = '') => | ||
| ({ children }) => ( | ||
| ({ children }: { children: React.ReactNode }) => ( |
There was a problem hiding this comment.
nit: This should be React.FC
ajay-sentry
reviewed
Jan 30, 2025
src/pages/PlanPage/PlanPage.tsx
Outdated
| @@ -61,6 +75,11 @@ function PlanPage() { | |||
| > | |||
| <PlanProvider> | |||
| <PlanBreadcrumb /> | |||
| {unverifiedPaymentMethods?.length ? ( | |||
There was a problem hiding this comment.
maybe .length > 0 rather than the property existing, but this is also falsey for the 0 case I believe.... maybe
There was a problem hiding this comment.
I think as is works, but I'll make it more explicit with the length check so it we don't have to double think
ajay-sentry
reviewed
Jan 30, 2025
| return ( | ||
| <> | ||
| <Alert variant="warning"> | ||
| <Alert.Title>Verify Your New Payment Method</Alert.Title> |
There was a problem hiding this comment.
nit: should double check caps on this
There was a problem hiding this comment.
That's the title and what @Adal3n3 suggested. I could go either way on that 🤷♀️
ajay-sentry
reviewed
Jan 30, 2025
| @@ -28,7 +28,7 @@ function CurrentOrgPlan() { | |||
| owner, | |||
| }) | |||
|
|
|||
| const { data: planData } = usePlanData({ | |||
| const { data: pageData } = useCurrentOrgPlanPageData({ | |||
There was a problem hiding this comment.
nit: can maybe just use data vs. pageData. Meaning is around the same but can avoid the cast
ajay-sentry
reviewed
Jan 30, 2025
| <InfoMessageStripeCallback /> | ||
| <InfoMessageStripeCallback | ||
| hasUnverifiedPaymentMethods={ | ||
| !!pageData?.billing?.unverifiedPaymentMethods?.length |
There was a problem hiding this comment.
nit: can maybe set this to a const at the top as hasUnverifiedPaymentMethods and use that for the awaitingInitialPaymentMethodVerification const
ajay-sentry
reviewed
Jan 30, 2025
| defaultOptions: { queries: { retry: false } }, | ||
| }) | ||
|
|
||
| const wrapper = ({ children }: { children: React.ReactNode }) => ( |
ajay-sentry
reviewed
Jan 30, 2025
| setup({ | ||
| owner: { | ||
| plan: { | ||
| value: Plans.USERS_INAPP, |
There was a problem hiding this comment.
nit: This plan is legacy, maybe we can use Plans.USERS_PR_INAPPY
ajay-sentry
reviewed
Jan 30, 2025
|
|
||
| const UnverifiedPaymentMethodSchema = z.object({ | ||
| paymentMethodId: z.string(), | ||
| hostedVerificationUrl: z.string(), |
There was a problem hiding this comment.
this is nullable right?
There was a problem hiding this comment.
ah nice good catch! fixed
ajay-sentry
reviewed
Jan 30, 2025
| }).then((res) => { | ||
| const parsedRes = CurrentOrgPlanPageDataSchema.safeParse(res?.data) | ||
| if (!parsedRes.success) { | ||
| return Promise.reject({ |
There was a problem hiding this comment.
nit: rejectNetworkError
ajay-sentry
reviewed
Jan 30, 2025
| @@ -0,0 +1,82 @@ | |||
| import { useQuery } from '@tanstack/react-queryV5' | |||
There was a problem hiding this comment.
nit: Could we scooch this next to be in the currentOrgPlan directory?
ajay-sentry
reviewed
Jan 30, 2025
| }) | ||
|
|
||
| interface UseUnverifiedPaymentMethodsArgs { | ||
| provider: string |
Bundle ReportChanges will increase total bundle size by 7.75kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
Files in
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3693 +/- ##
==========================================
- Coverage 98.78% 98.75% -0.03%
==========================================
Files 825 828 +3
Lines 14819 14875 +56
Branches 4203 4230 +27
==========================================
+ Hits 14639 14690 +51
- Misses 171 176 +5
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
|
@ajay-sentry thanks for reviewing! ready for another look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flows to handle when using ACH with async microdeposits. Changes in this PR cover below flows:
What "here" links to
codecov/engineering-team#2622