feat: Cut over to Stripe PaymentElement #3665
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
- Coverage 98.91% 98.80% -0.12%
==========================================
Files 817 820 +3
Lines 14716 14784 +68
Branches 4165 4206 +41
==========================================
+ Hits 14557 14608 +51
- Misses 152 167 +15
- Partials 7 9 +2
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
- Coverage 98.91% 98.80% -0.12%
==========================================
Files 817 820 +3
Lines 14716 14784 +68
Branches 4173 4206 +33
==========================================
+ Hits 14557 14608 +51
- Misses 152 167 +15
- Partials 7 9 +2
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
- Coverage 98.91% 98.80% -0.12%
==========================================
Files 817 820 +3
Lines 14716 14784 +68
Branches 4165 4214 +49
==========================================
+ Hits 14557 14608 +51
- Misses 152 167 +15
- Partials 7 9 +2
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will increase total bundle size by 12.2MB (100.49%) ⬆️
ℹ️ *Bundle size includes cached data from a previous commit |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
- Coverage 98.91% 98.80% -0.12%
==========================================
Files 817 820 +3
Lines 14716 14784 +68
Branches 4165 4206 +41
==========================================
+ Hits 14557 14608 +51
- Misses 152 167 +15
- Partials 7 9 +2
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
suejung-sentry
changed the title
suejung-sentry
force-pushed
the
sshin/stripe-2
branch
3 times, most recently
from
455f129 to
91a732a
Compare
suejung-sentry
force-pushed
the
sshin/stripe-2
branch
from
91a732a to
ea0b00d
Compare
suejung-sentry
force-pushed
the
sshin/stripe-2
branch
from
31557fe to
0d33704
Compare
| interface BankInformationProps { | ||
| subscriptionDetail: z.infer<typeof SubscriptionDetailSchema> | ||
| } | ||
| function BankInformation({ subscriptionDetail }: BankInformationProps) { |
There was a problem hiding this comment.
nit: can you get away with just passing bankAccount into this component?
There was a problem hiding this comment.
Good call - updated!
| provider, | ||
| owner, | ||
| name: | ||
| subscriptionDetail?.defaultPaymentMethod?.billingDetails?.name || |
There was a problem hiding this comment.
nit: Is it possible to pass just billingDetails to this component or set it to a const before this hook?
There was a problem hiding this comment.
True - set the const as suggested!
| @@ -213,3 +213,20 @@ export function useAccountDetails({ | |||
| ...opts, | |||
| }) | |||
| } | |||
|
|
|||
| export const stripeAddress = ( | |||
There was a problem hiding this comment.
Thoughts on keeping this next to where it's being used in PaymentMethodForm?
There was a problem hiding this comment.
Moved it, I like that!
| @@ -62,7 +67,9 @@ export function useUpdatePaymentMethod({ | |||
| payment_method_data: { | |||
| // eslint-disable-next-line camelcase | |||
| billing_details: { | |||
| name: name, | |||
There was a problem hiding this comment.
nit: I think we can tidy this up to { name, email, address }
There was a problem hiding this comment.
Nice - fixed!
suejung-sentry
force-pushed
the
sshin/stripe-2
branch
from
27c7e37 to
30b8561
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR adds ability to choose ACH as a payment method.
mode: setup, currency: usdas required per here, here if using the PaymentElement. Otherwise stripe console errors that mode or client secret missingACH won't actually be turned on until it is selected in the Stripe dashboard, but this PR gets things set up.
Closes codecov/engineering-team#3108
When ACH not yet turned on, the new PaymentElement for Card is shown below:
(old)
The view screen remains unchanged:
For ACH below are screenshots of the PaymentElement
